Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misbehaviour while showing dynamic content in the collapsible #113

Closed
ghost opened this issue Aug 14, 2017 · 13 comments
Closed

Misbehaviour while showing dynamic content in the collapsible #113

ghost opened this issue Aug 14, 2017 · 13 comments

Comments

@ghost
Copy link

ghost commented Aug 14, 2017

Hi,

i'm searching for a way, to do collapsibles the right thing!

Heres my example:
Dynamic content in collapsible

Heres my problem:
I would like to display some dynamic content in the collapsible. In this example, there will be some times displayed. Don't worry about the same times. I only would like to show some dynamic content.
First of all, the collapse property is set to false in the initial state of redux, but the collapsible is closed (collapsible=true?!?!).
The second misbehaviour is, when the collapsible is shown (collapse=false) and a timeout is set. Then the collapsible closes itself.

What am i doing wrong???

I would like to display some times in the collapsible, without having this misbehaviour of closing the collapsible itself.

Any suggestions?

@iRoachie
Copy link
Collaborator

Hey @Ralcon could you be a bit clearer? I'm not sure what you're asking exactly

@ghost
Copy link
Author

ghost commented Aug 15, 2017

Hi, i got the following problem:
My aim is to display several country times, updated by redux (every second via timeout), see my example. When i open the collapsible the first time, everything works fine and is displayed how it should be. but when i activate the timeout to render the information, the collapsible callapses itself. the variable to identify, if the collapsible is collapsed, is false all the time (a redux property). why is the collapsible collapse itself?
A little bit clearer?

@ghost
Copy link
Author

ghost commented Aug 20, 2017

The target state should be:

  • Open callaspsibles
  • Press "Start" button
  • New times are rendered every second

=> Collapsibles should stay 'open' (collapse={false})!

within the given example:
1. git clone https://github.com/ralcon/dynamic-content-in-collapsible
2. cd dynamic-content-in-collapsible
3. npm install
4. react-native run-ios

@dongawli
Copy link

@iRoachie : I am too facing the issue while showing dynamic controls in collapsible. Please see the video - https://hub.mangoapps.com/sf/MTAyNzA3XzEzODIxNzA

@poicooler
Copy link

Having the same issue. When i update a collapsible that is open, it renders nothing even if the collapsed props is at false.

@sfratini
Copy link

sfratini commented Jan 3, 2018

Maybe related to this I am facing: #137

@eduardomoroni
Copy link
Contributor

This solves this issue:
#147

@iRoachie
Copy link
Collaborator

Just merged #147. Release will be out in a few mins.

@iRoachie
Copy link
Collaborator

Released in v0.11.0

@dansanti
Copy link

dansanti commented Mar 7, 2021

Hello!
this bug is present in current version, pr #147 not merged

@wmonecke
Copy link

@dansanti I am still seeing issues when children inside Collapsible re-render. Did you manage to fix it?

@dansanti
Copy link

dansanti commented Mar 20, 2021

PR #147 fix it, you have to manually apply the patch

@wmonecke
Copy link

@dansanti It introduced flickering when my content changes height. Does that happen to you too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants