Use named components in translations #985
Conversation
MegaLinter status: ✅ SUCCESS
See errors details in artifact MegaLinter reports on CI Job page |
Codecov Report
@@ Coverage Diff @@
## master #985 +/- ##
=======================================
Coverage 88.20% 88.20%
=======================================
Files 99 99
Lines 1713 1713
Branches 396 396
=======================================
Hits 1511 1511
Misses 202 202
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| @@ -1466,13 +1466,7 @@ exports[`<CreateWalletPage /> should match snapshot 1`] = ` | |||
| > | |||
| <span | |||
| class="c17" | |||
| > | |||
| Save your keyphrase | |||
There was a problem hiding this comment.
Why this was wiped out from a snapshot?
There was a problem hiding this comment.
Mocked i18next doesn't include default string
(not sure if we should deviate from https://github.com/i18next/react-i18next/blob/master/example/test-jest/src/__mocks__/react-i18next.js just to add it back)
src/locales/en/translation.json
Outdated
| @@ -114,7 +114,7 @@ | |||
| "createWallet": { | |||
| "confirmSaved": "I saved my keyphrase", | |||
| "doNotShare": "Never share your keyphrase, anyone with your keyphrase can access your wallet and your tokens.", | |||
| "instruction": "Save your keyphrase <1>in the right order</1> in a secure location, you will need it to open your wallet.", | |||
| "instruction": "Save your keyphrase <strong>in the right order</strong> in a secure location, you will need it\n to open your wallet.", | |||
There was a problem hiding this comment.
Why you need those weird whitespaces and why only in EN?
There was a problem hiding this comment.
Oh, good catch. Must have come from yarn lint and yarn extract-messages
defaults="Save your keyphrase <strong>in the right order</strong> in a secure location, you will need it
to open your wallet."
lukaw3d
force-pushed
the
lw/named-trans
branch
from
545291b to
7429b49
Compare
No description provided.