Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change button border-radius in theme #947

Merged
merged 2 commits into from
Aug 1, 2022
Merged

Change button border-radius in theme #947

merged 2 commits into from
Aug 1, 2022

Conversation

lukaw3d
Copy link
Member

@lukaw3d lukaw3d commented Jul 30, 2022

Apparently all non-icon-buttons had customized style={{ borderRadius: '4px' }}

@lukaw3d lukaw3d requested a review from buberdds July 30, 2022 02:33
@github-actions
Copy link

MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ EDITORCONFIG editorconfig-checker 22 0 0.03s
✅ GIT git_diff yes no 0.01s
✅ TSX eslint 14 0 0 5.94s

See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

@codecov
Copy link

codecov bot commented Jul 30, 2022

Codecov Report

Merging #947 (96c1ddb) into master (9c27622) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #947   +/-   ##
=======================================
  Coverage   88.38%   88.38%           
=======================================
  Files          97       97           
  Lines        1670     1670           
  Branches      383      383           
=======================================
  Hits         1476     1476           
  Misses        194      194           
Flag Coverage Δ
cypress 58.45% <100.00%> (ø)
jest 79.30% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/app/components/AddEscrowForm/index.tsx 92.30% <ø> (ø)
src/app/components/FatalErrorHandler/index.tsx 71.42% <ø> (ø)
src/app/components/Modal/index.tsx 80.00% <ø> (ø)
src/app/components/ReclaimEscrowForm/index.tsx 100.00% <ø> (ø)
...ponents/Toolbar/Features/AccountSelector/index.tsx 100.00% <ø> (ø)
src/app/components/TransactionModal/index.tsx 91.66% <ø> (ø)
...ges/AccountPage/Features/SendTransaction/index.tsx 92.59% <ø> (ø)
src/app/pages/CreateWalletPage/index.tsx 90.90% <ø> (ø)
src/app/pages/HomePage/index.tsx 100.00% <ø> (ø)
...pages/OpenWalletPage/Features/FromLedger/index.tsx 68.42% <ø> (ø)
... and 4 more

@lukaw3d lukaw3d merged commit cdfbda5 into master Aug 1, 2022
@lukaw3d lukaw3d deleted the lw/btn-radius branch August 1, 2022 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants