-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Survive fetching delegations failures #879
Conversation
MegaLinter status: ✅ SUCCESS
See errors details in artifact MegaLinter reports on CI Job page |
Codecov Report
@@ Coverage Diff @@
## master #879 +/- ##
==========================================
- Coverage 88.41% 87.14% -1.28%
==========================================
Files 97 97
Lines 1606 1618 +12
Branches 336 347 +11
==========================================
- Hits 1420 1410 -10
- Misses 186 208 +22
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, @lukaw3d, I think these are great improvements!
Looking at the screenshots, I think it would make sense to make these warnings about unreachable API backends stand out a bit more.
I would perhaps try with a yellow warning theme like in the text below:
From UX perspective we are loosing an option to contact support and create support tickets via wallet@ email. Can we either bring back support related sentence? Mihnea is suggesting that we could move support notice to footer/disclaimer. |
{t('account.loadingError', "Couldn't load account. Information may be missing or out of date.")}{' '} | ||
{account.accountError} | ||
{t('account.loadingError', "Couldn't load account.")}{' '} | ||
<ErrorFormatter code={account.accountError.code} message={account.accountError.message} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tjanez Looking at the screenshots, I think it would make sense to make these warnings about unreachable API backends stand out a bit more.
choose:
error | warning |
---|---|
4313f66
to
4d06ddc
Compare
src/app/pages/CreateWalletPage/__tests__/__snapshots__/index.test.tsx.snap
Show resolved
Hide resolved
ac35292
to
5e50528
Compare
5e50528
to
f556050
Compare
Forgot to ask. With new type of error messages, do we still need to have disabled minification in production? |
yeah, there's still gRPC errors and potentially others |
Related to #403
(related cac52d1 and 6a59864)