Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix keyboard accessibility after creating a wallet #864

Merged
merged 3 commits into from
Jun 17, 2022
Merged

Conversation

lukaw3d
Copy link
Member

@lukaw3d lukaw3d commented Jun 16, 2022

lukaw3d added 2 commits June 16, 2022 23:32
After opening Layer inside Layer, some sidebar buttons couldn't be accessed by 
tab. Fixed by disabling an overlay in bottom Layer.
@lukaw3d lukaw3d requested review from buberdds and pro-wh June 16, 2022 22:03
@github-actions
Copy link

github-actions bot commented Jun 16, 2022

MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ EDITORCONFIG editorconfig-checker 7 0 0.02s
✅ GIT git_diff yes no 0.01s
✅ TSX eslint 6 0 0 5.18s

See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

@codecov
Copy link

codecov bot commented Jun 16, 2022

Codecov Report

Merging #864 (4eb371e) into master (05cd709) will decrease coverage by 0.05%.
The diff coverage is 40.00%.

@@            Coverage Diff             @@
##           master     #864      +/-   ##
==========================================
- Coverage   88.07%   88.01%   -0.06%     
==========================================
  Files         102      102              
  Lines        1643     1644       +1     
  Branches      340      340              
==========================================
  Hits         1447     1447              
- Misses        196      197       +1     
Flag Coverage Δ
cypress 58.00% <40.00%> (-0.04%) ⬇️
jest 74.93% <0.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/app/components/FatalErrorHandler/index.tsx 71.42% <ø> (ø)
src/app/components/Modal/index.tsx 80.00% <ø> (ø)
src/app/components/TransactionModal/index.tsx 91.66% <ø> (ø)
...pages/OpenWalletPage/Features/FromLedger/index.tsx 68.42% <ø> (ø)
src/app/pages/CreateWalletPage/index.tsx 90.90% <25.00%> (-2.85%) ⬇️
src/app/pages/AccountPage/index.tsx 97.43% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05cd709...4eb371e. Read the comment docs.

@lukaw3d lukaw3d merged commit e70b582 into master Jun 17, 2022
@lukaw3d lukaw3d deleted the lw/tabbing branch June 17, 2022 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Buttons aren't focusable by keyboard after user creates wallet
2 participants