You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
One benefit of this is: when you open a popup with stored state, it redirects to your wallet.
One issue is: it always redirects. Even if you have chrome-extension://jplembhokmkioddbchbohdfkmjdmepbb/popup.html#/create-wallet open as a tab, and reload.
Use cases:
when active wallet changes, redirect to it
when clicking extension icon to open popup, redirect to active wallet (ideally use history.replace)
or (Tadej's preference) clicking extension icon to open popup redirects to last url (ideally use history.replace)
(conflicts with "not to keep your routes in your Redux store at all" recommendation)
when reloading an existing popup, don't redirect
when opening popup with specific URL (e.g. to confirm dapp action), don't redirect
useRouteRedirects
This is tough. It was an effect in saga before (https://github.com/oasisprotocol/oasis-wallet-web/blob/5cebb40/src/app/state/wallet/saga.ts#L150) but saga now runs in background page.
One benefit of this is: when you open a popup with stored state, it redirects to your wallet.
One issue is: it always redirects. Even if you have
chrome-extension://jplembhokmkioddbchbohdfkmjdmepbb/popup.html#/create-wallet
open as a tab, and reload.Use cases:
(conflicts with "not to keep your routes in your Redux store at all" recommendation)
Originally posted by @lukaw3d in #787 (comment)
The text was updated successfully, but these errors were encountered: