Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't detect pending transactions if no nonce in 20 latest transactions #2022

Merged
merged 4 commits into from
Jul 30, 2024

Conversation

lukaw3d
Copy link
Member

@lukaw3d lukaw3d commented Jul 30, 2024

Fixes #2007

@lukaw3d lukaw3d requested a review from lubej July 30, 2024 01:20
Copy link

github-actions bot commented Jul 30, 2024

Deployed to Cloudflare Pages

Latest commit: e9fdf1f3e36d3da70161cf64311b2aada3953b0e
Status:✅ Deploy successful!
Preview URL: https://6fb51510.oasis-wallet.pages.dev

@lukaw3d lukaw3d force-pushed the lw/better-pending branch from 08c615d to 1a8cd9d Compare July 30, 2024 01:24
@lukaw3d lukaw3d force-pushed the lw/better-pending branch from 1a8cd9d to e9fdf1f Compare July 30, 2024 01:32

const currentAddress = 'oasis1qz78ap0456g2rk7j6rmtvasc9v2kjhz2s58qgj90'

describe('hasAccountUnknownPendingTransactions', () => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tests seem like duplication of src/app/pages/AccountPage/Features/TransactionHistory/__tests__/index.test.tsx, but since they are unit tests, looks fine.

@lukaw3d lukaw3d merged commit bf38bb3 into master Jul 30, 2024
12 of 13 checks passed
@lukaw3d lukaw3d deleted the lw/better-pending branch July 30, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some accounts always show "Some transactions are currently in a pending state."
2 participants