Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint rule to detect broken Google Translate in CommissionBounds #1984

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

lukaw3d
Copy link
Member

@lukaw3d lukaw3d commented Jun 20, 2024

Related to #1982
The reason #1983 was needed is:

  • CommissionBounds returned <>string</>
  • details ? <CommissionBounds /> : <Spinner /> conditionally inserted it

The reason d85c5ff was needed is:
- `CommissionBounds` returned <>string</>
- `details ? <CommissionBounds /> : <Spinner />` conditionally inserted it
@lukaw3d lukaw3d requested a review from buberdds June 20, 2024 20:10
Copy link

github-actions bot commented Jun 20, 2024

Deployed to Cloudflare Pages

Latest commit: 0622983f4c4dec73fcea75351db73f5b56b7f973
Status:✅ Deploy successful!
Preview URL: https://6a0fdfff.oasis-wallet.pages.dev

@lukaw3d lukaw3d merged commit e630cde into master Jun 21, 2024
13 checks passed
@lukaw3d lukaw3d deleted the lw/extend-google-translate-lint branch June 21, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants