Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove incognito mode button (haven't removed all the related code) #1914

Merged
merged 1 commit into from
May 8, 2024

Conversation

lukaw3d
Copy link
Member

@lukaw3d lukaw3d commented May 3, 2024

Related to #1861

Before After
localhost_3000_account_oasis1qrtyn2q78jv6plrmexrsrv4dh89wv4n49udtg2km(extension375x600 + scrollbar) (1) localhost_3000_account_oasis1qrtyn2q78jv6plrmexrsrv4dh89wv4n49udtg2km(extension375x600 + scrollbar)

@lukaw3d lukaw3d requested review from buberdds and lubej May 3, 2024 22:30
Copy link

github-actions bot commented May 3, 2024

Deployed to Cloudflare Pages

Latest commit: f3397c5bddc718c32c5e69d1226e3791e5ceb4b5
Status:✅ Deploy successful!
Preview URL: https://8aeb1b36.oasis-wallet.pages.dev

@lubej
Copy link
Collaborator

lubej commented May 4, 2024

The issue relates to mobile/extension. But this would remove the feature on desktop as well, right?
I would rather see that all code related to this feature removal, was contained in this PR. Unless there is a urgent reason not to.

@lukaw3d lukaw3d force-pushed the lw/remove-incognito-btn branch from 9ad5468 to f3397c5 Compare May 8, 2024 01:35
@lukaw3d lukaw3d merged commit 016dfa1 into master May 8, 2024
12 of 13 checks passed
@lukaw3d lukaw3d deleted the lw/remove-incognito-btn branch May 8, 2024 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants