Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include security headers in the build and release #1845

Merged
merged 1 commit into from
Feb 12, 2024
Merged

Conversation

lukaw3d
Copy link
Member

@lukaw3d lukaw3d commented Feb 12, 2024

No description provided.

@lukaw3d lukaw3d requested a review from buberdds February 12, 2024 15:32
Copy link

github-actions bot commented Feb 12, 2024

Deployed to Cloudflare Pages

Latest commit: 2ee6a1517516e6efa3b5f3062682f2792ca39137
Status:✅ Deploy successful!
Preview URL: https://a6fd0931.oasis-wallet.pages.dev

Copy link
Contributor

@buberdds buberdds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this meant to be used by devops somewhere in TF scripts?

@lukaw3d
Copy link
Member Author

lukaw3d commented Feb 12, 2024

Possibly

But mainly to make releases actually self contained. When trying to deploy before:

  • you had to download the release zip
  • find the corresponding release job, and read the build output to find the headers in stdout
    (or risk inconsistency with checking out the released commit and run build locally)

@lukaw3d lukaw3d enabled auto-merge February 12, 2024 17:00
Copy link

codecov bot commented Feb 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d21de39) 81.17% compared to head (a83ca8d) 81.17%.

❗ Current head a83ca8d differs from pull request most recent head 2ee6a15. Consider uploading reports for the commit 2ee6a15 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1845   +/-   ##
=======================================
  Coverage   81.17%   81.17%           
=======================================
  Files         192      192           
  Lines        5067     5067           
  Branches      932      932           
=======================================
  Hits         4113     4113           
  Misses        954      954           
Flag Coverage Δ
cypress 46.20% <ø> (ø)
jest 76.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@lukaw3d lukaw3d merged commit e73dbba into master Feb 12, 2024
11 of 12 checks passed
@lukaw3d lukaw3d deleted the lw/release-headers branch February 12, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants