-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add V0 extension migration UI #1783
Conversation
Deployed to Cloudflare Pages
|
export async function deleteV0ExtProfile() { | ||
if (runtimeIs !== 'extension') throw new Error('Can only delete V0 profile in an extension') | ||
const browser = await import('webextension-polyfill') | ||
await browser.storage.local.remove('keyringData') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing that I would immediately suggest, let's not delete the migrated encrypted data. Let's save it under different key, keyringDataMigrated
or something similar. In case there is a migration edge case we have not foreseen, we can always push a new version to fix it. And after certain time period(1-3 months), push a new version, that would clean up the migration data. The data is encoded, it shouldn't pose any security risk, it should only benefit us.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1783 +/- ##
==========================================
- Coverage 82.36% 81.35% -1.01%
==========================================
Files 188 190 +2
Lines 4956 5064 +108
Branches 912 934 +22
==========================================
+ Hits 4082 4120 +38
- Misses 874 944 +70
Flags with carried forward coverage won't be shown. Click here to find out more.
|
extract-messages |
Does Address book -> Contact migration work? |
e2e test says Address book to contacts works (walletExtensionV0UnlockedState). To manually try it you need to add localStorage.ADDRESS_BOOK_CONFIG |
a3e2870
to
c15a9b9
Compare
c15a9b9
to
9a79df8
Compare
To load main test data:
inspect new extension's popup and run:
Password:
Abcd1234&
Or get your data from old extension: