Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused eslint disable directives #1381

Merged
merged 1 commit into from
Apr 4, 2023
Merged

Conversation

lukaw3d
Copy link
Member

@lukaw3d lukaw3d commented Apr 4, 2023

No description provided.

@lukaw3d lukaw3d requested a review from buberdds April 4, 2023 15:34
@github-actions
Copy link

github-actions bot commented Apr 4, 2023

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ EDITORCONFIG editorconfig-checker 5 0 0.02s
✅ JAVASCRIPT eslint 2 0 0 4.31s
✅ REPOSITORY checkov yes no 16.39s
✅ REPOSITORY git_diff yes no 0.01s
✅ TSX eslint 1 0 0 4.3s
✅ TYPESCRIPT eslint 2 0 0 3.6s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Apr 4, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 2b7ceff
Status: ✅  Deploy successful!
Preview URL: https://893d60d6.oasis-wallet.pages.dev
Branch Preview URL: https://lw-unused-eslint-disable.oasis-wallet.pages.dev

View logs

@lukaw3d lukaw3d force-pushed the lw/unused-eslint-disable branch from 4fbee4a to 2b7ceff Compare April 4, 2023 16:05
@codecov
Copy link

codecov bot commented Apr 4, 2023

Codecov Report

Merging #1381 (2b7ceff) into master (ba12995) will increase coverage by 0.08%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1381      +/-   ##
==========================================
+ Coverage   84.32%   84.40%   +0.08%     
==========================================
  Files         143      143              
  Lines        3687     3687              
  Branches      674      674              
==========================================
+ Hits         3109     3112       +3     
+ Misses        578      575       -3     
Flag Coverage Δ
cypress 51.32% <0.00%> (ø)
jest 79.32% <0.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/app/components/Persist/UnlockForm.tsx 40.74% <0.00%> (ø)

... and 1 file with indirect coverage changes

@lukaw3d lukaw3d merged commit 0ce6e55 into master Apr 4, 2023
@lukaw3d lukaw3d deleted the lw/unused-eslint-disable branch April 4, 2023 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants