Downgrade to latest playwright (ledger window doesn't crash Chromium) #1338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukaw3d
changed the title
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports MegaLinter is graciously provided by |
buberdds
approved these changes
Mar 17, 2023
lukaw3d
force-pushed
the
lw/latest-playwright
branch
from
a8b09e4 to
568c22a
Compare
Deploying with
|
| Latest commit: |
568c22a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7220a14b.oasis-wallet.pages.dev |
| Branch Preview URL: | https://lw-latest-playwright.oasis-wallet.pages.dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During #1321 I needed playwright prerelease to test if popup would ask for permissions after it no longer crashed Chromium.
It did not ask for permissions, so as a workaround I open a normal window instead of a popup. This asks for permissions and doesn't crash Chromium 110.x/111.x. With this workaround we no longer need prerelease, and we can test against latest browsers instead.