Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Oasis Protocol dependencies #1323

Merged
merged 2 commits into from
Mar 16, 2023

Conversation

buberdds
Copy link
Contributor

@buberdds buberdds commented Mar 15, 2023

@codecov
Copy link

codecov bot commented Mar 15, 2023

Codecov Report

Merging #1323 (fe1ce03) into master (251cce0) will increase coverage by 0.15%.
The diff coverage is 50.00%.

❗ Current head fe1ce03 differs from pull request most recent head 5b2b307. Consider uploading reports for the commit 5b2b307 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1323      +/-   ##
==========================================
+ Coverage   84.59%   84.74%   +0.15%     
==========================================
  Files         142      142              
  Lines        3602     3606       +4     
  Branches      660      660              
==========================================
+ Hits         3047     3056       +9     
+ Misses        555      550       -5     
Flag Coverage Δ
cypress 51.60% <100.00%> (+0.30%) ⬆️
jest 80.08% <0.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/app/pages/E2EPage/index.tsx 40.90% <50.00%> (+40.90%) ⬆️

Copy link
Member

@lukaw3d lukaw3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😮‍💨 after all those cypress updates, cypress still denies optional chaining

Comment on lines +12 to +13
window.monitor = monitor
window.oasisscan = oasisscan
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: this executes even if developer opens /open-wallet. Move into E2EPage?

@buberdds buberdds merged commit ced3bae into oasisprotocol:master Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants