Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove @testing-library/react-hooks and jest-watch-typeahead #1251

Merged
merged 2 commits into from
Jan 19, 2023

Conversation

lukaw3d
Copy link
Member

@lukaw3d lukaw3d commented Jan 18, 2023

  • @testing-library/react-hooks is now consolidated into @testing-library/react
  • jest-watch-typeahead was throwing warnings and I doubt anyone uses it much

@lukaw3d lukaw3d requested a review from buberdds January 18, 2023 22:57
@github-actions
Copy link

github-actions bot commented Jan 18, 2023

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ EDITORCONFIG editorconfig-checker 6 0 0.02s
✅ JAVASCRIPT eslint 1 0 0 3.93s
✅ JSON eslint-plugin-jsonc 1 0 0 0.69s
✅ JSON jsonlint 1 0 0.19s
✅ JSON npm-package-json-lint yes no 0.44s
✅ JSON prettier 1 0 0 0.43s
✅ JSON v8r 1 0 4.15s
✅ REPOSITORY checkov yes no 11.71s
✅ REPOSITORY git_diff yes no 0.01s
✅ TYPESCRIPT eslint 3 0 0 4.53s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@codecov
Copy link

codecov bot commented Jan 18, 2023

Codecov Report

Merging #1251 (59dce52) into master (4edc4f1) will increase coverage by 0.11%.
The diff coverage is n/a.

❗ Current head 59dce52 differs from pull request most recent head b79ff7c. Consider uploading reports for the commit b79ff7c to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1251      +/-   ##
==========================================
+ Coverage   80.51%   80.63%   +0.11%     
==========================================
  Files         141      141              
  Lines        2659     2659              
  Branches      654      654              
==========================================
+ Hits         2141     2144       +3     
+ Misses        518      515       -3     
Flag Coverage Δ
cypress 51.32% <ø> (ø)
jest 73.88% <ø> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/app/state/account/saga.ts 88.67% <0.00%> (+5.66%) ⬆️

@lukaw3d lukaw3d force-pushed the lw/remove-test-react-hooks branch from 59dce52 to b79ff7c Compare January 19, 2023 17:17
@lukaw3d lukaw3d merged commit da0cc84 into master Jan 19, 2023
@lukaw3d lukaw3d deleted the lw/remove-test-react-hooks branch January 19, 2023 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants