-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add version tag in footer #1192
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1192 +/- ##
==========================================
+ Coverage 80.29% 80.61% +0.32%
==========================================
Files 141 141
Lines 2654 2657 +3
Branches 652 654 +2
==========================================
+ Hits 2131 2142 +11
+ Misses 523 515 -8
Flags with carried forward coverage won't be shown. Click here to find out more.
|
865eb43
to
4f10e55
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's merge two last commits into one something like "Open footer links in a new tab".
optional: in terms of guards we could either check tag format in UI or maybe just add comment in gh action next to fetch-depth that it's needed to render footer correctly.
19e4650
to
1471c92
Compare
1471c92
to
3c530fd
Compare
Issue
Closes #1118
Solution
Latest tag(version) should be displayed in the footer, linking to the matching tag in releases.
git describe --tags --abbrev=0
gets the latest single tag in commit history - possible to add--exact-match
, to show only tags on current commit, but will break test builds;REACT_APP_BUILD_VERSION
added forvx.x
tag;Caveats
git describe --tags --abbrev=0
will throw an error, if there are no tags added - which is probably what we want anyway.