Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix displayAccountNumber #1179

Merged
merged 2 commits into from
Nov 29, 2022
Merged

Fix displayAccountNumber #1179

merged 2 commits into from
Nov 29, 2022

Conversation

lukaw3d
Copy link
Member

@lukaw3d lukaw3d commented Nov 29, 2022

Broken since I rebased #990 over 3255d9b: it started displaying 0', 1', .. as account numbers

@lukaw3d lukaw3d requested review from buberdds and csillag November 29, 2022 04:14
@github-actions
Copy link

github-actions bot commented Nov 29, 2022

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ EDITORCONFIG editorconfig-checker 4 0 0.07s
✅ REPOSITORY checkov yes no 19.82s
✅ REPOSITORY git_diff yes no 0.01s
✅ TSX eslint 3 0 0 6.06s

See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@codecov
Copy link

codecov bot commented Nov 29, 2022

Codecov Report

Merging #1179 (0d612e3) into master (eb3b33d) will increase coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1179      +/-   ##
==========================================
+ Coverage   80.93%   81.05%   +0.11%     
==========================================
  Files         140      140              
  Lines        2639     2639              
  Branches      648      648              
==========================================
+ Hits         2136     2139       +3     
+ Misses        503      500       -3     
Flag Coverage Δ
cypress 51.52% <100.00%> (ø)
jest 74.25% <100.00%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ge/Features/ImportAccountsSelectionModal/index.tsx 86.84% <ø> (ø)
...ponents/Toolbar/Features/AccountSelector/index.tsx 100.00% <100.00%> (ø)
src/app/state/account/saga.ts 88.67% <0.00%> (+5.66%) ⬆️

@lukaw3d lukaw3d merged commit f41b721 into master Nov 29, 2022
@lukaw3d lukaw3d deleted the lw/fix-acc-num branch November 29, 2022 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants