Move route address validation from AccountPage into routes #1145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦙 MegaLinter status: ✅ SUCCESS
See errors details in artifact MegaLinter reports on CI Job page MegaLinter is graciously provided by |
Codecov Report
@@ Coverage Diff @@
## master #1145 +/- ##
==========================================
- Coverage 84.91% 84.52% -0.40%
==========================================
Files 126 127 +1
Lines 2374 2384 +10
Branches 570 574 +4
==========================================
- Hits 2016 2015 -1
- Misses 358 369 +11
Flags with carried forward coverage won't be shown. Click here to find out more.
|
lukaw3d
force-pushed
the
lw/route-validation
branch
2 times, most recently
from
110c65e to
ef11ea1
Compare
buberdds
reviewed
Nov 14, 2022
src/app/pages/AccountPage/index.tsx
Outdated
| <AlertBox color={'status-error'}>{t('errors.invalidAddress', 'Invalid address')}</AlertBox> | ||
| </Box> | ||
| ) | ||
| export async function validateRoute(params: AccountPageParams) { |
buberdds
approved these changes
Nov 14, 2022
| @@ -29,6 +25,10 @@ export const commonRoutes: Route[] = [ | |||
| { | |||
| path: 'account/:address/*', | |||
| element: <AccountPage />, | |||
| errorElement: <ErrorBoundary></ErrorBoundary>, | |||
| loader: async ({ params }) => { | |||
There was a problem hiding this comment.
Oddly it works that way too, but all documentation and router code looks like it intends loader to return a Response or Promise. I'd keep it
lukaw3d
force-pushed
the
lw/route-validation
branch
from
234ba02 to
79430aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1004 (comment)
and #1079 (comment)