Add playwright #1119
Merged
Add playwright #1119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦙 MegaLinter status: ✅ SUCCESS
See errors details in artifact MegaLinter reports on CI Job page MegaLinter is graciously provided by |
lukaw3d
force-pushed
the
lw/playwright
branch
4 times, most recently
from
c08038c to
a98c506
Compare
lukaw3d
commented
Oct 28, 2022
.github/workflows/build-test.yaml
Outdated
Comment on lines
69
to
72
| - run: yarn install --frozen-lockfile | ||
| working-directory: playwright | ||
| - run: npx playwright install --with-deps | ||
| working-directory: playwright |
There was a problem hiding this comment.
Note, after yarn install playwright needs more steps to start working https://playwright.dev/docs/cli#install-system-dependencies
lukaw3d
commented
Oct 28, 2022
Comment on lines
+1
to
+8
| { | ||
| "scripts": { | ||
| "test": "playwright test" | ||
| }, | ||
| "devDependencies": { | ||
| "@playwright/test": "1.27.1" | ||
| } | ||
| } |
There was a problem hiding this comment.
It is isolated in a separate folder for now
buberdds
approved these changes
Oct 28, 2022
lukaw3d
force-pushed
the
lw/playwright
branch
from
a98c506 to
e0fd8a8
Compare
lukaw3d
force-pushed
the
lw/playwright
branch
from
9fc459f to
d657c49
Compare
lukaw3d
force-pushed
the
lw/playwright
branch
from
d657c49 to
81d9940
Compare
Codecov Report
@@ Coverage Diff @@
## master #1119 +/- ##
==========================================
+ Coverage 83.68% 83.90% +0.22%
==========================================
Files 121 121
Lines 2249 2249
Branches 539 539
==========================================
+ Hits 1882 1887 +5
+ Misses 367 362 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Merging this despite failed CI, because it accurately shows that production build on master is broken |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #975
Part of #1061