Extract PasswordField from FromPrivateKey #1018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MegaLinter status: ✅ SUCCESS
See errors details in artifact MegaLinter reports on CI Job page |
Codecov Report
@@ Coverage Diff @@
## master #1018 +/- ##
==========================================
+ Coverage 88.78% 88.85% +0.06%
==========================================
Files 100 101 +1
Lines 1748 1750 +2
Branches 405 405
==========================================
+ Hits 1552 1555 +3
+ Misses 196 195 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
lukaw3d
force-pushed
the
lw/extract-password-field
branch
from
3b98bf5 to
9a77a7b
Compare
csillag
approved these changes
Sep 22, 2022
csillag
reviewed
Sep 22, 2022
| </Tip> | ||
| </Box> | ||
| </FormField> | ||
| ></PasswordField> |
There was a problem hiding this comment.
This could be a self closing tag.
There was a problem hiding this comment.
Changed. I don't really care tho
If it is good practice then we should add react/self-closing-comp
lukaw3d
force-pushed
the
lw/extract-password-field
branch
from
9a77a7b to
e0855a5
Compare
lukaw3d
force-pushed
the
lw/extract-password-field
branch
from
d6a2a2d to
bd32f34
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just making it reusable for persisted state