Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move useIonicRequiresUpdate state #1969

Merged
merged 1 commit into from
Jun 7, 2024
Merged

Conversation

lubej
Copy link
Collaborator

@lubej lubej commented Jun 7, 2024

No description provided.

Copy link

github-actions bot commented Jun 7, 2024

Deployed to Cloudflare Pages

Latest commit: 412f2845ec8d34e5de8380cfeb128d01c91800ff
Status:✅ Deploy successful!
Preview URL: https://6b6e3a39.oasis-wallet.pages.dev

@lubej lubej force-pushed the ml/app-update-wall-follow-up branch from b8ef6ea to 412f284 Compare June 7, 2024 04:11
@lubej lubej mentioned this pull request Jun 7, 2024
@lubej lubej requested a review from lukaw3d June 7, 2024 04:13
@lubej lubej marked this pull request as ready for review June 7, 2024 04:13
Copy link

codecov bot commented Jun 7, 2024

Codecov Report

Attention: Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 79.62%. Comparing base (fa89f31) to head (b8ef6ea).
Report is 15 commits behind head on master.

Current head b8ef6ea differs from pull request most recent head 412f284

Please upload reports for the commit 412f284 to get more accurate results.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1969      +/-   ##
==========================================
- Coverage   79.70%   79.62%   -0.09%     
==========================================
  Files         210      210              
  Lines        5411     5409       -2     
  Branches     1001     1001              
==========================================
- Hits         4313     4307       -6     
- Misses       1098     1102       +4     
Flag Coverage Δ
cypress 43.91% <40.00%> (+0.01%) ⬆️
jest 75.70% <62.50%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...p/components/Ionic/components/UpdateGate/index.tsx 46.66% <ø> (ø)
src/app/components/Ionic/providers/IonicContext.ts 100.00% <ø> (ø)
...c/app/components/Ionic/providers/IonicProvider.tsx 50.00% <50.00%> (+3.33%) ⬆️
...p/components/Ionic/hooks/useIonicRequiresUpdate.ts 26.31% <66.66%> (+1.31%) ⬆️

... and 7 files with indirect coverage changes

@lubej lubej merged commit 812d62e into master Jun 7, 2024
13 checks passed
@lubej lubej deleted the ml/app-update-wall-follow-up branch June 7, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants