-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restyle "Buy ROSE" page and open Transak in new tab on small screens #1966
Conversation
Deployed to Cloudflare Pages
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1966 +/- ##
==========================================
- Coverage 80.52% 80.24% -0.29%
==========================================
Files 204 203 -1
Lines 5290 5289 -1
Branches 968 974 +6
==========================================
- Hits 4260 4244 -16
- Misses 1030 1045 +15
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can confirm it works fine on mobile.
Not a fan that user's wallet address being sent via get parameters, even though it should be encrypted. Would be better if this was sent via a header or something. Just something to consider.
Disable responsively switching between iframe and link to open in new tab.
8e03ea7
to
06fb9d7
Compare
If extension popup closes you lose all progress and it's too small to fit embedded widget.