Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restyle "Buy ROSE" page and open Transak in new tab on small screens #1966

Merged
merged 5 commits into from
Jun 4, 2024

Conversation

lukaw3d
Copy link
Member

@lukaw3d lukaw3d commented May 31, 2024

If extension popup closes you lose all progress and it's too small to fit embedded widget.

Before After
wallet dev oasis io_account_oasis1qrtyn2q78jv6plrmexrsrv4dh89wv4n49udtg2km_fiat0 localhost_3000_account_oasis1qrtyn2q78jv6plrmexrsrv4dh89wv4n49udtg2km_fiat
wallet dev oasis io_account_oasis1qrtyn2q78jv6plrmexrsrv4dh89wv4n49udtg2km_fiat1 localhost_3000_account_oasis1qrtyn2q78jv6plrmexrsrv4dh89wv4n49udtg2km_fiat (1)
wallet dev oasis io_account_oasis1qrtyn2q78jv6plrmexrsrv4dh89wv4n49udtg2km_fiat(mocks1440x700)0 localhost_3000_account_oasis1qrtyn2q78jv6plrmexrsrv4dh89wv4n49udtg2km_fiat (2)
wallet dev oasis io_account_oasis1qrtyn2q78jv6plrmexrsrv4dh89wv4n49udtg2km_fiat(mocks1440x700)1 localhost_3000_account_oasis1qrtyn2q78jv6plrmexrsrv4dh89wv4n49udtg2km_fiat (3)

@lukaw3d lukaw3d requested review from buberdds and lubej May 31, 2024 21:09
Copy link

github-actions bot commented May 31, 2024

Deployed to Cloudflare Pages

Latest commit: 7494b78afb5aa887192313cb890c5fb9c3d15f7c
Status:✅ Deploy successful!
Preview URL: https://5eabce5f.oasis-wallet.pages.dev

Copy link

codecov bot commented May 31, 2024

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Project coverage is 80.24%. Comparing base (bb8d0e2) to head (fa2db40).
Report is 13 commits behind head on master.

Current head fa2db40 differs from pull request most recent head 7494b78

Please upload reports for the commit 7494b78 to get more accurate results.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1966      +/-   ##
==========================================
- Coverage   80.52%   80.24%   -0.29%     
==========================================
  Files         204      203       -1     
  Lines        5290     5289       -1     
  Branches      968      974       +6     
==========================================
- Hits         4260     4244      -16     
- Misses       1030     1045      +15     
Flag Coverage Δ
cypress 44.51% <0.00%> (-0.05%) ⬇️
jest 76.23% <0.00%> (-0.29%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/app/pages/FiatOnrampPage/index.tsx 0.00% <0.00%> (ø)

... and 7 files with indirect coverage changes

Copy link
Collaborator

@lubej lubej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm it works fine on mobile.

Not a fan that user's wallet address being sent via get parameters, even though it should be encrypted. Would be better if this was sent via a header or something. Just something to consider.

src/app/pages/FiatOnrampPage/index.tsx Outdated Show resolved Hide resolved
playwright/tests/extension.spec.ts Outdated Show resolved Hide resolved
src/app/pages/FiatOnrampPage/index.tsx Outdated Show resolved Hide resolved
@lukaw3d lukaw3d force-pushed the lw/transak-restyle branch from 8e03ea7 to 06fb9d7 Compare June 4, 2024 12:11
@lukaw3d lukaw3d merged commit 2864790 into master Jun 4, 2024
13 checks passed
@lukaw3d lukaw3d deleted the lw/transak-restyle branch June 4, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants