Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Capacitor to v6 #1957

Merged
merged 1 commit into from
May 28, 2024
Merged

Upgrade Capacitor to v6 #1957

merged 1 commit into from
May 28, 2024

Conversation

buberdds
Copy link
Contributor

@buberdds buberdds commented May 28, 2024

APK seems Ok after updates. I am not fully able to test Ledger though. That part was not working for me earlier too (I can select BLE device, but cannot list accounts - shows USB Transport error).

Copy link

github-actions bot commented May 28, 2024

Deployed to Cloudflare Pages

Latest commit: 1a509c78de4df5bb42347fd71c7e5d3923da7ef5
Status:✅ Deploy successful!
Preview URL: https://20227bbd.oasis-wallet.pages.dev

Copy link

socket-security bot commented May 28, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@babel/[email protected] None 0 4.21 kB nicolo-ribaudo
npm/@babel/[email protected] None 0 6.94 kB nicolo-ribaudo
npm/@babel/[email protected] None 0 12.5 kB nicolo-ribaudo
npm/@babel/[email protected] None 0 80 kB nicolo-ribaudo
npm/@capacitor-community/[email protected] None +1 649 kB pwespi
npm/@capacitor/[email protected] None 0 428 kB ionicjs
npm/@capacitor/[email protected] None 0 65.5 kB ionicjs
npm/@capacitor/[email protected] environment, filesystem, network, shell +26 3.91 MB ionicjs
npm/@capacitor/[email protected] network 0 394 kB ionicjs
npm/@capacitor/[email protected] None 0 375 kB ionicjs
npm/@noble/[email protected] None 0 1.39 MB paulmillr
npm/@oasisprotocol/[email protected] None 0 32 kB oasisprotocol-bot
npm/[email protected] None 0 24.4 kB rreverser
npm/[email protected] None 0 493 kB marijn
npm/[email protected] None 0 25.4 kB ljharb
npm/[email protected] None +2 31.5 kB ljharb
npm/[email protected] None +2 31.9 kB ljharb
npm/[email protected] environment 0 11.4 kB pfmooney
npm/[email protected] filesystem Transitive: environment, unsafe +5 559 kB d-fischer
npm/[email protected] None +2 46.3 kB ljharb
npm/[email protected] None +2 48.7 kB ljharb
npm/[email protected] None +31 3.65 MB ljharb
npm/[email protected] None +10 249 kB ljharb
npm/[email protected] filesystem +1 109 kB mrmlnc
npm/[email protected] None +1 48.3 kB matteo.collina
npm/[email protected] filesystem +2 97.2 kB jaredwray
npm/[email protected] None +1 42.2 kB ljharb
npm/[email protected] Transitive: filesystem +1 20.2 kB sindresorhus
npm/[email protected] None +2 36.8 kB ljharb
npm/[email protected] None +1 41.1 kB ljharb
npm/[email protected] None 0 22.2 kB ljharb
npm/[email protected] None 0 17.6 kB ljharb
npm/[email protected] environment 0 41.8 kB simenb
npm/[email protected] None +2 1.43 MB ljharb
npm/[email protected] environment 0 8.13 kB sindresorhus
npm/[email protected] None 0 31.4 kB ljharb
npm/[email protected] None 0 15.6 kB ljharb
npm/[email protected] None 0 30.9 kB ljharb
npm/[email protected] None 0 4.05 kB isaacs
npm/[email protected] None 0 6.17 kB sindresorhus
npm/[email protected] None 0 5.41 kB sindresorhus
npm/[email protected] environment +1 118 kB ljharb

🚮 Removed packages: npm/@capacitor-community/[email protected], npm/@capacitor/[email protected], npm/@capacitor/[email protected], npm/@capacitor/[email protected], npm/@capacitor/[email protected], npm/@capacitor/[email protected], npm/@oasisprotocol/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

@buberdds buberdds marked this pull request as ready for review May 28, 2024 10:15
package.json Outdated Show resolved Hide resolved
@lubej
Copy link
Collaborator

lubej commented May 28, 2024

I can confirm connecting & listing accounts works for me for Bluetooth Ledger for this dependency updates.

@buberdds can you check permissions for the application? And is you Nano X paired with the phone?
I can't think of any other reason, why it wouldn't work.

@buberdds
Copy link
Contributor Author

Yes it is paired otherwise I would not be able to see it on "Select Ledger Device" BLE list. Maybe I messed with developer settings. Anyway will try using different phone today.

@buberdds buberdds merged commit d942d77 into master May 28, 2024
13 checks passed
@buberdds buberdds deleted the mz/cap branch May 28, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants