Improve the text for creating a profile #1913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deployed to Cloudflare Pages
|
lubej
reviewed
May 3, 2024
| "repeatPassword": "Re-enter your password", | ||
| "startPersisting": "Store private keys locally, protected by a password", | ||
| "repeatPassword": "Confirm your password", | ||
| "startPersisting": "Store your private keys locally and protect them with a password by creating a profile.", |
There was a problem hiding this comment.
"Securely store your private keys on your local device, protected by a password."?
| "repeatPassword": "Confirm your password", | ||
| "startPersisting": "Store your private keys locally and protect them with a password by creating a profile.", | ||
| "startPersistingToggle": "Create a profile", | ||
| "undependableAcknowledge": "I understand this password and profile do not substitute my mnemonic.", |
There was a problem hiding this comment.
I understand that neither password or profile serve as a substitution for my mnemonic.
There was a problem hiding this comment.
cc @donouwens do you want to iterate more on it
There was a problem hiding this comment.
(i'm merging in current state just to avoid code conflict, and will revisit)
lubej
approved these changes
May 3, 2024
lukaw3d
force-pushed
the
lw/text-create-profile
branch
from
a40b1fa to
73b81fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mocks:
