Update profile deletion text #1869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deployed to Cloudflare Pages
|
buberdds
approved these changes
Apr 5, 2024
| @@ -33,7 +33,7 @@ export function DeleteProfileButton({ prominent }: DeleteProfileButtonProps) { | |||
| <> | |||
| <Button | |||
| color="status-error" | |||
| label={t('persist.loginToProfile.deleteProfile.button', 'Delete profile')} | |||
| label={t('persist.loginToProfile.deleteProfile.button', 'Forgot password?')} | |||
There was a problem hiding this comment.
Can we take into account the second context where button is used? When user has an open profile we will show "Forget password?" in Profile tab.
There was a problem hiding this comment.
Checking this variant with Don:
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1869 +/- ##
==========================================
+ Coverage 81.31% 81.34% +0.03%
==========================================
Files 193 193
Lines 5095 5099 +4
Branches 939 943 +4
==========================================
+ Hits 4143 4148 +5
+ Misses 952 951 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
lukaw3d
force-pushed
the
lw/profile-delete-text
branch
from
0ad34ff to
43ccf68
Compare
lukaw3d
force-pushed
the
lw/profile-delete-text
branch
from
43ccf68 to
fe45c54
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don agrees