Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Delete Account button layout on mobile #1836

Merged
merged 3 commits into from
Jan 25, 2024
Merged

Conversation

lukaw3d
Copy link
Member

@lukaw3d lukaw3d commented Jan 25, 2024

Before After
localhost_3000_account_oasis1qrnzhcl8nap2f0p730qeedmjmuhtw9hnhv6urnee(extension360x600) (1) localhost_3000_account_oasis1qrnzhcl8nap2f0p730qeedmjmuhtw9hnhv6urnee(extension360x600) (1)
localhost_3000_account_oasis1qrnzhcl8nap2f0p730qeedmjmuhtw9hnhv6urnee(extension360x600) localhost_3000_account_oasis1qrnzhcl8nap2f0p730qeedmjmuhtw9hnhv6urnee(extension360x600)
localhost_3000_account_oasis1qrnzhcl8nap2f0p730qeedmjmuhtw9hnhv6urnee(iPhone XR) localhost_3000_account_oasis1qrnzhcl8nap2f0p730qeedmjmuhtw9hnhv6urnee(iPhone XR) (1)
localhost_3000_account_oasis1qrnzhcl8nap2f0p730qeedmjmuhtw9hnhv6urnee(iPhone XR) (1) localhost_3000_account_oasis1qrnzhcl8nap2f0p730qeedmjmuhtw9hnhv6urnee(iPhone XR)

@lukaw3d lukaw3d requested a review from buberdds January 25, 2024 15:24
Copy link

github-actions bot commented Jan 25, 2024

Deployed to Cloudflare Pages

Latest commit: fd5550313e5511b95736dbd56325105b789fd844
Status:✅ Deploy successful!
Preview URL: https://f9746160.oasis-wallet.pages.dev

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (64e1c01) 81.13% compared to head (b279b05) 81.13%.

❗ Current head b279b05 differs from pull request most recent head fd55503. Consider uploading reports for the commit fd55503 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1836   +/-   ##
=======================================
  Coverage   81.13%   81.13%           
=======================================
  Files         192      192           
  Lines        5057     5058    +1     
  Branches      933      932    -1     
=======================================
+ Hits         4103     4104    +1     
  Misses        954      954           
Flag Coverage Δ
cypress 46.08% <66.66%> (+0.04%) ⬆️
jest 76.96% <66.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/app/components/Persist/DeleteProfileButton.tsx 75.00% <ø> (-0.87%) ⬇️
src/app/components/Persist/UnlockForm.tsx 55.55% <ø> (ø)
...lbar/Features/Account/ManageableAccountDetails.tsx 41.37% <66.66%> (+2.09%) ⬆️

@lukaw3d
Copy link
Member Author

lukaw3d commented Jan 25, 2024

Transak fail

@lukaw3d lukaw3d merged commit ff431bd into master Jan 25, 2024
11 of 12 checks passed
@lukaw3d lukaw3d deleted the lw/delete-acc-btn branch January 25, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants