Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add yaml schema to markdownlint configs #1828

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Add yaml schema to markdownlint configs #1828

merged 1 commit into from
Jan 16, 2024

Conversation

lukaw3d
Copy link
Member

@lukaw3d lukaw3d commented Jan 16, 2024

Adds code-completion, at least in vscode. Should this be propagated to everywhere?

@lukaw3d lukaw3d requested review from buberdds, csillag and lubej January 16, 2024 01:55
Copy link

github-actions bot commented Jan 16, 2024

Deployed to Cloudflare Pages

Latest commit: eb82307c330091d86f4b7d1189d9db952d7ee34c
Status:✅ Deploy successful!
Preview URL: https://d804bb0f.oasis-wallet.pages.dev

Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e32d603) 81.29% compared to head (af61952) 81.47%.
Report is 1 commits behind head on master.

❗ Current head af61952 differs from pull request most recent head eb82307. Consider uploading reports for the commit eb82307 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1828      +/-   ##
==========================================
+ Coverage   81.29%   81.47%   +0.17%     
==========================================
  Files         192      192              
  Lines        5053     5042      -11     
  Branches      933      923      -10     
==========================================
  Hits         4108     4108              
+ Misses        945      934      -11     
Flag Coverage Δ
cypress 46.05% <ø> (ø)
jest 77.30% <ø> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

Copy link
Contributor

@buberdds buberdds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do you invoke code-completion here?
I don't see any differences between master branch for ctrl+space or when I type something in yaml

@lukaw3d
Copy link
Member Author

lukaw3d commented Jan 16, 2024

@lukaw3d lukaw3d force-pushed the lw/markdown-schema branch from af61952 to eb82307 Compare January 16, 2024 20:39
@lukaw3d lukaw3d enabled auto-merge January 16, 2024 20:39
@lukaw3d lukaw3d merged commit 8ac76d6 into master Jan 16, 2024
9 of 10 checks passed
@lukaw3d lukaw3d deleted the lw/markdown-schema branch January 16, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants