Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n: Add German (62%) and Spanish (29%) partial translations #1817

Merged
merged 1 commit into from
Dec 22, 2023

Conversation

lukaw3d
Copy link
Member

@lukaw3d lukaw3d commented Dec 21, 2023

No description provided.

@lukaw3d lukaw3d requested a review from matevz December 21, 2023 23:14
Copy link

github-actions bot commented Dec 21, 2023

Deployed to Cloudflare Pages

Latest commit: fbdbc8d682833bbe976fda6aeccaa8a67aa1ada1
Status:✅ Deploy successful!
Preview URL: https://a11b6fa8.oasis-wallet.pages.dev

Copy link

codecov bot commented Dec 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (956119b) 81.39% compared to head (b2c12a4) 81.32%.
Report is 1 commits behind head on master.

❗ Current head b2c12a4 differs from pull request most recent head fbdbc8d. Consider uploading reports for the commit fbdbc8d to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1817      +/-   ##
==========================================
- Coverage   81.39%   81.32%   -0.08%     
==========================================
  Files         192      192              
  Lines        5037     5039       +2     
  Branches      926      926              
==========================================
- Hits         4100     4098       -2     
- Misses        937      941       +4     
Flag Coverage Δ
cypress 46.10% <ø> (ø)
jest 77.17% <100.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/locales/i18n.ts 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

Copy link
Member

@matevz matevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can merge this and hopefully trigger German and Spanish users to improve the translation.

@lukaw3d lukaw3d enabled auto-merge December 22, 2023 21:16
@lukaw3d lukaw3d merged commit e88631f into master Dec 22, 2023
10 checks passed
@lukaw3d lukaw3d deleted the lw/new-langs branch December 22, 2023 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants