Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Account #1752

Merged
merged 5 commits into from
Nov 10, 2023
Merged

Remove Account #1752

merged 5 commits into from
Nov 10, 2023

Conversation

buberdds
Copy link
Contributor

@buberdds buberdds commented Nov 8, 2023

Wallet re-design: Profile modal
We are missing Remove Account feature and we need to update Profile tab https://www.figma.com/file/WRFccTgeZKKBM0jE9gFCWS/Wallet-%2F-Persisted-State?type=design&node-id=0-1&mode=design&t=XTOl8do287YBRmxe-0

After discussion with Don:

  • We won't have to track previous selected accounts. We will open the first one on the list if needed
  • We don't need special modal when user cannot remove an account

Copy link

github-actions bot commented Nov 8, 2023

Deployed to Cloudflare Pages

Latest commit: e6be568183dfa29c71026f50017fcfcfad934f13
Status:✅ Deploy successful!
Preview URL: https://d416bdf2.oasis-wallet.pages.dev

@buberdds buberdds changed the title Mz/acc remove Remove Account Nov 8, 2023
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Merging #1752 (e6be568) into master (d5f94e6) will decrease coverage by 0.41%.
The diff coverage is 55.73%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1752      +/-   ##
==========================================
- Coverage   82.92%   82.52%   -0.41%     
==========================================
  Files         183      185       +2     
  Lines        4673     4720      +47     
  Branches      836      846      +10     
==========================================
+ Hits         3875     3895      +20     
- Misses        798      825      +27     
Flag Coverage Δ
cypress 48.36% <25.00%> (-0.29%) ⬇️
jest 78.15% <52.45%> (-0.45%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/app/components/Persist/DeleteProfileButton.tsx 79.16% <100.00%> (+8.19%) ⬆️
...pp/components/Toolbar/Features/Account/Account.tsx 91.89% <100.00%> (-0.22%) ⬇️
src/app/state/wallet/selectors.ts 94.44% <100.00%> (+0.69%) ⬆️
...nts/Toolbar/Features/Account/ManageableAccount.tsx 77.77% <60.00%> (-4.05%) ⬇️
...ponents/Toolbar/Features/AccountSelector/index.tsx 92.00% <71.42%> (-8.00%) ⬇️
...ponents/Toolbar/Features/Account/DeleteAccount.tsx 71.42% <71.42%> (ø)
src/app/state/wallet/index.ts 78.26% <20.00%> (-16.19%) ⬇️
src/app/components/DeleteInputForm/index.tsx 58.33% <58.33%> (ø)
...lbar/Features/Account/ManageableAccountDetails.tsx 37.50% <28.57%> (-3.41%) ⬇️

... and 2 files with indirect coverage changes

@buberdds buberdds marked this pull request as ready for review November 8, 2023 15:42
@buberdds buberdds requested a review from lukaw3d November 8, 2023 15:58
src/locales/en/translation.json Outdated Show resolved Hide resolved
src/locales/en/translation.json Outdated Show resolved Hide resolved
playwright/tests/toolbar.spec.ts Show resolved Hide resolved
@buberdds buberdds force-pushed the mz/accRemove branch 4 times, most recently from 0ce6d66 to b766663 Compare November 10, 2023 12:46
@buberdds buberdds mentioned this pull request Nov 10, 2023
@buberdds buberdds merged commit baf8166 into master Nov 10, 2023
11 of 12 checks passed
@buberdds buberdds deleted the mz/accRemove branch November 10, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants