Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contacts overlap issue fix #1696

Merged
merged 2 commits into from
Oct 3, 2023
Merged

Contacts overlap issue fix #1696

merged 2 commits into from
Oct 3, 2023

Conversation

buberdds
Copy link
Contributor

@buberdds buberdds commented Oct 3, 2023

  • Remove Box that is causing overlap issue (when user has many contacts)
  • unify scrollable container in Accounts and Contacts

current master
Screenshot 2023-10-03 at 13 59 31

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 3, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 528985c
Status: ✅  Deploy successful!
Preview URL: https://b9308b65.oasis-wallet.pages.dev
Branch Preview URL: https://mz-contactlistfix.oasis-wallet.pages.dev

View logs

@buberdds buberdds changed the title Contact overlap issue fix Contacts overlap issue fix Oct 3, 2023
@buberdds buberdds requested a review from lukaw3d October 3, 2023 12:05
@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Merging #1696 (528985c) into master (1f5e54c) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1696      +/-   ##
==========================================
+ Coverage   82.90%   82.93%   +0.03%     
==========================================
  Files         178      179       +1     
  Lines        4562     4572      +10     
  Branches      816      816              
==========================================
+ Hits         3782     3792      +10     
  Misses        780      780              
Flag Coverage Δ
cypress 48.52% <83.33%> (+0.09%) ⬆️
jest 78.70% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...pp/components/Toolbar/Features/Account/Account.tsx 92.10% <ø> (ø)
...ponents/Toolbar/Features/AccountSelector/index.tsx 100.00% <100.00%> (ø)
...nents/Toolbar/Features/Contacts/ContactAccount.tsx 58.33% <ø> (ø)
...app/components/Toolbar/Features/Contacts/index.tsx 91.89% <100.00%> (ø)
...nts/Toolbar/Features/ScrollableContainer/index.tsx 100.00% <100.00%> (ø)
src/app/components/Toolbar/Features/layer.ts 100.00% <100.00%> (ø)

>
{accounts}
</Box>
<ScrollableContainer>{accounts}</ScrollableContainer>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@buberdds buberdds merged commit 71001ff into master Oct 3, 2023
12 checks passed
@buberdds buberdds deleted the mz/contactListFix branch October 3, 2023 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants