Add tests to Address Book #1657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
05a0460
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a448ee22.oasis-wallet.pages.dev |
| Branch Preview URL: | https://mz-addrtests.oasis-wallet.pages.dev |
Codecov Report
@@ Coverage Diff @@
## master #1657 +/- ##
==========================================
+ Coverage 81.31% 82.50% +1.19%
==========================================
Files 171 171
Lines 4345 4345
Branches 777 777
==========================================
+ Hits 3533 3585 +52
+ Misses 812 760 -52
Flags with carried forward coverage won't be shown. Click here to find out more.
|
buberdds
force-pushed
the
mz/addrTests
branch
2 times, most recently
from
7556486 to
14e90bf
Compare
buberdds
changed the title
lukaw3d
approved these changes
Sep 12, 2023
| renderComponent(store) | ||
| await userEvent.click(screen.getByRole('button', { name: 'toolbar.contacts.save' })) | ||
| expect(screen.getAllByText('toolbar.contacts.validation.required').length).toEqual(2) | ||
| expect(onSave).not.toHaveBeenCalled() |
| .fill('oasis1qq2vzcvxn0js5unsch5me2xz4kr43vcasv0d5eq4') | ||
| await tab2.getByRole('button', { name: 'Save' }).click() | ||
| await expect(tab2.getByTestId('account-choice')).toHaveCount(1) | ||
| await expect(page.getByTestId('account-choice')).toHaveCount(1) |
There was a problem hiding this comment.
(potential additional e2e: expect not to sync if user changes name and cancels)
buberdds
force-pushed
the
mz/addrTests
branch
from
14e90bf to
17afdc4
Compare
buberdds
force-pushed
the
mz/addrTests
branch
from
17afdc4 to
05a0460
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.