Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for max messages per runtime context #112

Closed
ptrus opened this issue Apr 29, 2021 · 0 comments · Fixed by #121
Closed

Add tests for max messages per runtime context #112

ptrus opened this issue Apr 29, 2021 · 0 comments · Fixed by #121
Assignees
@ptrus
Labels
c:runtime-sdk Category: Runtime SDK c:testing Category: testing

Comments

@ptrus
Copy link
Member

ptrus commented Apr 29, 2021

Since we are adding a new message this should actually be:

        if self.messages.len() >= self.max_messages as usize {

Also would be cool to have a test for this.

Originally posted by @kostko in #92 (comment)
@ptrus ptrus mentioned this issue Apr 29, 2021
Merged
6 tasks
@kostko kostko added c:runtime-sdk Category: Runtime SDK c:testing Category: testing labels Apr 29, 2021
@ptrus ptrus self-assigned this May 4, 2021
@ptrus ptrus mentioned this issue May 4, 2021
Merged
@ptrus ptrus closed this as completed in #121 May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ptrus ptrus

Labels
c:runtime-sdk Category: Runtime SDK c:testing Category: testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

runtime-sdk: test max messages in context oasisprotocol/oasis-sdk
2 participants
@kostko @ptrus