Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ubuntu docker base image #257

Merged
merged 8 commits into from
Feb 3, 2022
Merged

Use ubuntu docker base image #257

merged 8 commits into from
Feb 3, 2022

Conversation

pro-wh
Copy link
Collaborator

@pro-wh pro-wh commented Nov 19, 2021

Here's a variant that's not based on Alpine.

It's a little janky though, with the build being done on Debian and the runtime being Ubuntu.

Can't really explain why, but the criterion of a specifically "Ubuntu based" dockerfile came up.

@pro-wh
Copy link
Collaborator Author

pro-wh commented Nov 19, 2021

Do we have something that tests a Docker image? I've only gotten as far as the docker build finishing.

@pro-wh pro-wh force-pushed the pro-wh/feature/ubuntudocker branch 2 times, most recently from 6ba2741 to 0177b4c Compare January 10, 2022 23:15
@pro-wh
Copy link
Collaborator Author

pro-wh commented Jan 11, 2022

issues with this currently:

  • we can't reference new files in the dockerfile due to it downloading the repo from github (master). thanks, rosetta rules. working around this by pointing it to this branch instead. and now I have to push in order to make any changes. and we'll have to revert that after merging. dirty
  • I haven't set up ci to build the ubuntu version. could, I suppose
  • maybe we should port some later changes over to the alpine one, e.g. to ship genesis and config files
  • there's too much duplication

@pro-wh pro-wh force-pushed the pro-wh/feature/ubuntudocker branch 3 times, most recently from 3b5d707 to 8847f6a Compare January 11, 2022 22:27
@pro-wh pro-wh changed the title (experimental) add ubuntu-based docker image add ubuntu-based docker image Jan 12, 2022
@pro-wh
Copy link
Collaborator Author

pro-wh commented Jan 12, 2022

Our partner has been able to use this successfully with the public testnet. Let's open this up for review.

docker-ubuntu/Dockerfile Outdated Show resolved Hide resolved
Copy link
Member

@tjanez tjanez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pro-wh, can you update the PR to replace the existing Docker image files in docker directory instead of adding a new side-by-side docker-ubuntu directory?

@pro-wh
Copy link
Collaborator Author

pro-wh commented Feb 2, 2022

@tjanez oh ok yeah

@pro-wh pro-wh force-pushed the pro-wh/feature/ubuntudocker branch from 8847f6a to 03cf42c Compare February 2, 2022 20:38
@pro-wh pro-wh changed the title add ubuntu-based docker image Use ubuntu docker base image Feb 2, 2022
@pro-wh
Copy link
Collaborator Author

pro-wh commented Feb 2, 2022

I'm going to remove that commit to change over the branch name before merging after all.

@pro-wh pro-wh force-pushed the pro-wh/feature/ubuntudocker branch from 03cf42c to a3c367a Compare February 2, 2022 21:59
@pro-wh
Copy link
Collaborator Author

pro-wh commented Feb 2, 2022

docker ci workflow passes. I'll remove the branch change before merging

@pro-wh pro-wh force-pushed the pro-wh/feature/ubuntudocker branch from a3c367a to 3815661 Compare February 2, 2022 22:55
@pro-wh
Copy link
Collaborator Author

pro-wh commented Feb 2, 2022

oh right, I can't because we use some evil combination of the current branch and master branch

@pro-wh pro-wh force-pushed the pro-wh/feature/ubuntudocker branch 7 times, most recently from 2dbce6b to f99bb5f Compare February 3, 2022 00:38
@pro-wh pro-wh force-pushed the pro-wh/feature/ubuntudocker branch from f99bb5f to ee488da Compare February 3, 2022 00:39
@pro-wh
Copy link
Collaborator Author

pro-wh commented Feb 3, 2022

aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa

@pro-wh pro-wh force-pushed the pro-wh/feature/ubuntudocker branch 2 times, most recently from 1fdea2c to 1be8cea Compare February 3, 2022 00:50
@pro-wh
Copy link
Collaborator Author

pro-wh commented Feb 3, 2022

  Running [/home/runner/golangci-lint-1.39.0-linux-amd64/golangci-lint run --out-format=github-actions] in [] ...
  level=error msg="Timeout exceeded: try increasing it by passing --timeout option"
$ golangci-lint --timeout
ERRO Can't get config for command line: can't parse args: flag needs an argument: --timeout
$ golangci-lint --help
Smart, fast linters runner. Run it in cloud for every GitHub pull request on https://golangci.com

Usage:
  golangci-lint [flags]
  golangci-lint [command]

Available Commands:
  cache       Cache control and information
  completion  Output completion script
  config      Config
  help        Help
  linters     List current linters configuration
  run         Run the linters
  version     Version

Flags:
      --color string              Use color when printing; can be 'always', 'auto', or 'never' (default "auto")
  -j, --concurrency int           Concurrency (default NumCPU) (default 8)
      --cpu-profile-path string   Path to CPU profile output file
  -h, --help                      help for golangci-lint
      --mem-profile-path string   Path to memory profile output file
      --trace-path string         Path to trace output file
  -v, --verbose                   verbose output
      --version                   Print version

Use "golangci-lint [command] --help" for more information about a command.
$ golangci-lint --timeout 5m
Error: unknown flag: --timeout

💀

@pro-wh pro-wh force-pushed the pro-wh/feature/ubuntudocker branch from 1be8cea to 271fa1a Compare February 3, 2022 00:57
@pro-wh pro-wh requested a review from tjanez February 3, 2022 01:04
@pro-wh
Copy link
Collaborator Author

pro-wh commented Feb 3, 2022

re-requesting @tjanez for advice on gitlint on changelog fragments

@pro-wh pro-wh force-pushed the pro-wh/feature/ubuntudocker branch from 271fa1a to 28be57a Compare February 3, 2022 23:11
@pro-wh
Copy link
Collaborator Author

pro-wh commented Feb 3, 2022

rebased, removing that branch change again

gonna try some ignore-body-lines shenanigans today

@pro-wh pro-wh force-pushed the pro-wh/feature/ubuntudocker branch from 28be57a to a64037f Compare February 3, 2022 23:31
@pro-wh
Copy link
Collaborator Author

pro-wh commented Feb 3, 2022

thanks @tjanez for this part:

<!--
gitlint-ignore: body-max-line-length
-->

@pro-wh pro-wh merged commit 213eacd into master Feb 3, 2022
@pro-wh pro-wh deleted the pro-wh/feature/ubuntudocker branch February 3, 2022 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants