From 310b1ad09c57863de14130bb0409af89f57299b9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tadej=20Jane=C5=BE?= Date: Mon, 12 Apr 2021 12:07:36 +0200 Subject: [PATCH 1/2] go/upgrade: Add work-around for incorrect go-fuzz instrumentation This fixes broken build of go/fuzz-consensus. --- go/upgrade/api/api.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/go/upgrade/api/api.go b/go/upgrade/api/api.go index 8d287ceca7e..5039d2aee2b 100644 --- a/go/upgrade/api/api.go +++ b/go/upgrade/api/api.go @@ -128,7 +128,8 @@ func (d Descriptor) ValidateBasic() error { if err := d.Target.ValidateBasic(); err != nil { return fmt.Errorf("invalid upgrade descriptor target version: %w", err) } - if d.Epoch < MinUpgradeEpoch || d.Epoch > MaxUpgradeEpoch { + minUpgradeEpoch, maxUpgradeEpoch := MinUpgradeEpoch, MaxUpgradeEpoch // Work-around for incorrect go-fuzz instrumentation. + if d.Epoch < minUpgradeEpoch || d.Epoch > maxUpgradeEpoch { return fmt.Errorf("invalid upgrade descriptor epoch: %d (min: %d max: %d)", d.Epoch, MinUpgradeEpoch, From 130a3166117f5c0bdeba882c46928c57c18e3b1d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tadej=20Jane=C5=BE?= Date: Mon, 12 Apr 2021 12:19:24 +0200 Subject: [PATCH 2/2] go/worker/compute/executor: Enable transaction checks by default --- .changelog/3851.feature.md | 1 + go/worker/compute/executor/init.go | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) create mode 100644 .changelog/3851.feature.md diff --git a/.changelog/3851.feature.md b/.changelog/3851.feature.md new file mode 100644 index 00000000000..d9ca21ee40c --- /dev/null +++ b/.changelog/3851.feature.md @@ -0,0 +1 @@ +go/worker/compute/executor: Enable scheduler transaction checks by default diff --git a/go/worker/compute/executor/init.go b/go/worker/compute/executor/init.go index 8933752ea66..faeaff8e041 100644 --- a/go/worker/compute/executor/init.go +++ b/go/worker/compute/executor/init.go @@ -39,7 +39,7 @@ func New( } func init() { - Flags.Bool(CfgScheduleCheckTxEnabled, false, "Enable checking transactions before scheduling them") + Flags.Bool(CfgScheduleCheckTxEnabled, true, "Enable checking transactions before scheduling them") Flags.Uint64(cfgMaxTxPoolSize, 10000, "Maximum size of the scheduling transaction pool") Flags.Uint64(cfgScheduleTxCacheSize, 1000, "Cache size of recently scheduled transactions to prevent re-scheduling")