Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move halt epoch from genesis to node-local configuration #5200

Merged
merged 1 commit into from
Feb 25, 2023

Conversation

kostko
Copy link
Member

@kostko kostko commented Feb 24, 2023

No description provided.

@kostko kostko force-pushed the kostko/feature/remove-halt-epoch branch from 1e9f8a5 to a874809 Compare February 24, 2023 13:10
@kostko kostko marked this pull request as ready for review February 24, 2023 13:10
@kostko kostko force-pushed the kostko/feature/remove-halt-epoch branch from a874809 to da6de8d Compare February 24, 2023 13:27
@codecov
Copy link

codecov bot commented Feb 24, 2023

Codecov Report

Merging #5200 (da6de8d) into master (61b37fc) will increase coverage by 0.26%.
The diff coverage is 71.42%.

❗ Current head da6de8d differs from pull request most recent head 4d474b9. Consider uploading reports for the commit 4d474b9 to get more accurate results

@@            Coverage Diff             @@
##           master    #5200      +/-   ##
==========================================
+ Coverage   61.38%   61.64%   +0.26%     
==========================================
  Files         512      512              
  Lines       54055    54051       -4     
==========================================
+ Hits        33181    33322     +141     
+ Misses      16649    16506     -143     
+ Partials     4225     4223       -2     
Impacted Files Coverage Δ
go/consensus/tendermint/abci/mux.go 45.21% <0.00%> (-1.09%) ⬇️
go/consensus/tendermint/full/archive.go 0.00% <ø> (ø)
go/consensus/tendermint/full/common.go 57.31% <ø> (+0.73%) ⬆️
go/genesis/api/api.go 73.91% <ø> (ø)
go/genesis/api/sanity_check.go 76.92% <ø> (-1.65%) ⬇️
go/consensus/tendermint/config/config.go 75.36% <33.33%> (-1.92%) ⬇️
go/consensus/tendermint/abci/state.go 68.85% <66.66%> (+1.14%) ⬆️
go/consensus/tendermint/full/full.go 52.32% <100.00%> (-0.39%) ⬇️
go/consensus/tendermint/tests/genesis/genesis.go 91.72% <100.00%> (-0.06%) ⬇️
go/oasis-node/cmd/genesis/genesis.go 54.19% <100.00%> (-0.18%) ⬇️
... and 28 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

go/consensus/tendermint/config/config.go Outdated Show resolved Hide resolved
go/consensus/tendermint/abci/state.go Outdated Show resolved Hide resolved
@kostko kostko force-pushed the kostko/feature/remove-halt-epoch branch from da6de8d to 4d474b9 Compare February 25, 2023 14:33
@kostko kostko enabled auto-merge February 25, 2023 14:33
@kostko kostko merged commit da35fe3 into master Feb 25, 2023
@kostko kostko deleted the kostko/feature/remove-halt-epoch branch February 25, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants