Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime/src/protocol: Remove consensus version compatibility check #5135

Merged
merged 1 commit into from
Jan 16, 2023

Conversation

peternose
Copy link
Contributor

Consensus version check was a sanity check which didn't allow dump-restore upgrades. The removal did no harm as the consensus version was never authenticated and light clients use the verifier to check state compatibility and authenticity.

Consensus version check was a sanity check which didn't allow dump-restore
upgrades. The removal did no harm as the consensus version was never
authenticated and light clients use the verifier to check state compatibility
and authenticity.
@codecov
Copy link

codecov bot commented Jan 16, 2023

Codecov Report

Merging #5135 (1e625b6) into master (e0045ab) will decrease coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5135      +/-   ##
==========================================
- Coverage   66.92%   66.83%   -0.09%     
==========================================
  Files         496      496              
  Lines       53271    53271              
==========================================
- Hits        35652    35606      -46     
- Misses      13279    13331      +52     
+ Partials     4340     4334       -6     
Impacted Files Coverage Δ
...onsensus/tendermint/apps/beacon/state/state_vrf.go 73.33% <0.00%> (-13.34%) ⬇️
go/governance/api/api.go 73.55% <0.00%> (-6.62%) ⬇️
go/runtime/host/sandbox/sandbox.go 70.00% <0.00%> (-6.56%) ⬇️
go/scheduler/api/api.go 53.26% <0.00%> (-6.53%) ⬇️
go/worker/beacon/tx_retry.go 90.47% <0.00%> (-4.77%) ⬇️
go/registry/api/sanity_check.go 73.10% <0.00%> (-2.66%) ⬇️
go/consensus/tendermint/light/p2p/p2p.go 67.32% <0.00%> (-2.62%) ⬇️
go/registry/api/api.go 52.57% <0.00%> (-2.43%) ⬇️
go/common/grpc/grpc.go 79.59% <0.00%> (-2.02%) ⬇️
go/p2p/peermgmt/discovery.go 82.40% <0.00%> (-1.86%) ⬇️
... and 28 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@peternose peternose merged commit 39c93c2 into master Jan 16, 2023
@peternose peternose deleted the peternose/internal/remove-consensus-version-check branch January 16, 2023 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants