Fix storage sync from non-empty genesis and p2p multi call dispatch #5005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If checkpoint sync is disabled but sync has been forced (e.g. because the state at genesis is non-empty), we must request to sync the checkpoint at genesis as otherwise we will jump to a later state which may not be desired given that checkpoint sync has been explicitly disabled via config.
Otherwise the shown state would be misleading, e.g. showing that it is waiting for runtime host being provisioned while it is actually blocked in initialization like storage sync.
kostko
force-pushed
the
kostko/fix/rt-cp-sync-p2p-multicall
branch
from
ca81c1c to
601be6d
Compare
kostko
requested review from
Yawning,
peterjgilbert,
pro-wh and
ptrus
as code owners
ptrus
approved these changes
Oct 28, 2022
Yawning
approved these changes
Oct 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.