Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/runtime/host: Make sure runtime-reported version matches bundle #4825

Merged
merged 2 commits into from
Jun 28, 2022

Conversation

kostko
Copy link
Member

@kostko kostko commented Jun 27, 2022

No description provided.

@kostko kostko force-pushed the kostko/fix/rt-host-early-vercheck branch 2 times, most recently from ee91616 to c7e9345 Compare June 27, 2022 15:06
@codecov
Copy link

codecov bot commented Jun 27, 2022

Codecov Report

Merging #4825 (c7e9345) into master (b27d959) will increase coverage by 0.04%.
The diff coverage is 0.00%.

❗ Current head c7e9345 differs from pull request most recent head cdf8224. Consider uploading reports for the commit cdf8224 to get more accurate results

@@            Coverage Diff             @@
##           master    #4825      +/-   ##
==========================================
+ Coverage   66.56%   66.61%   +0.04%     
==========================================
  Files         452      452              
  Lines       50334    50322      -12     
==========================================
+ Hits        33506    33521      +15     
+ Misses      12665    12641      -24     
+ Partials     4163     4160       -3     
Impacted Files Coverage Δ
go/runtime/host/sandbox/sandbox.go 60.40% <0.00%> (-0.42%) ⬇️
go/worker/common/p2p/rpc/server.go 80.76% <0.00%> (-9.62%) ⬇️
go/consensus/tendermint/apps/staking/auth.go 62.96% <0.00%> (-7.41%) ⬇️
go/common/cbor/codec.go 78.37% <0.00%> (-5.41%) ⬇️
go/common/sgx/common.go 66.01% <0.00%> (-3.89%) ⬇️
go/sentry/api/grpc.go 40.62% <0.00%> (-3.13%) ⬇️
go/oasis-node/cmd/ias/auth_registry.go 65.81% <0.00%> (-2.57%) ⬇️
go/worker/common/p2p/rpc/client.go 80.93% <0.00%> (-1.87%) ⬇️
go/oasis-node/cmd/stake/delegations.go 78.99% <0.00%> (-1.69%) ⬇️
go/runtime/host/protocol/connection.go 68.42% <0.00%> (-1.51%) ⬇️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2be0e7...cdf8224. Read the comment docs.

@kostko kostko marked this pull request as ready for review June 27, 2022 15:43
@kostko kostko enabled auto-merge June 27, 2022 16:57
@kostko kostko force-pushed the kostko/fix/rt-host-early-vercheck branch from c7e9345 to 8520b15 Compare June 28, 2022 07:07
These epoch transitions can happen quickly and can cause the nodes to
expire and cause runtimes to be suspended, making the test deadlock.
@kostko kostko force-pushed the kostko/fix/rt-host-early-vercheck branch from 8520b15 to cdf8224 Compare June 28, 2022 10:00
@kostko kostko merged commit b83c83f into master Jun 28, 2022
@kostko kostko deleted the kostko/fix/rt-host-early-vercheck branch June 28, 2022 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants