Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/runtime/registry: Refresh key manager policy on runtime changes #4729

Merged
merged 2 commits into from
May 4, 2022

Conversation

kostko
Copy link
Member

@kostko kostko commented May 4, 2022

Since the runtime can change dynamically (due to version upgrades), we
need to make sure that we notify the new runtime as well.

Since the runtime can change dynamically (due to version upgrades), we
need to make sure that we notify the new runtime as well.
@kostko kostko force-pushed the kostko/fix/rt-km-policy-update branch from 19dc240 to deb880c Compare May 4, 2022 07:57
@kostko kostko marked this pull request as ready for review May 4, 2022 08:11
@codecov
Copy link

codecov bot commented May 4, 2022

Codecov Report

Merging #4729 (3f56208) into master (ad8247e) will increase coverage by 0.08%.
The diff coverage is 68.75%.

@@            Coverage Diff             @@
##           master    #4729      +/-   ##
==========================================
+ Coverage   66.77%   66.86%   +0.08%     
==========================================
  Files         440      440              
  Lines       49240    49254      +14     
==========================================
+ Hits        32881    32934      +53     
+ Misses      12287    12280       -7     
+ Partials     4072     4040      -32     
Impacted Files Coverage Δ
go/runtime/registry/host.go 70.20% <68.75%> (-1.66%) ⬇️
go/consensus/tendermint/apps/staking/auth.go 62.96% <0.00%> (-7.41%) ⬇️
go/runtime/host/sandbox/sandbox.go 59.85% <0.00%> (-6.70%) ⬇️
go/oasis-node/cmd/ias/auth_registry.go 64.10% <0.00%> (-4.28%) ⬇️
go/sentry/api/grpc.go 40.62% <0.00%> (-3.13%) ⬇️
go/common/grpc/grpc.go 79.88% <0.00%> (-2.37%) ⬇️
go/runtime/host/multi/multi.go 72.05% <0.00%> (-1.48%) ⬇️
go/worker/compute/executor/committee/node.go 69.33% <0.00%> (-0.99%) ⬇️
go/registry/api/grpc.go 43.42% <0.00%> (-0.62%) ⬇️
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f916d66...3f56208. Read the comment docs.

@kostko kostko force-pushed the kostko/fix/rt-km-policy-update branch from 5448fc3 to 3f56208 Compare May 4, 2022 09:17
@kostko kostko merged commit a0404b1 into master May 4, 2022
@kostko kostko deleted the kostko/fix/rt-km-policy-update branch May 4, 2022 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants