Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/worker/compute: Only advertise active version for TEE runtimes #4683

Merged
merged 2 commits into from
Apr 22, 2022

Conversation

kostko
Copy link
Member

@kostko kostko commented Apr 22, 2022

Otherwise this will cause additional downtime on upgrades due to
capability updates not being allowed.

@kostko kostko added the c:bug Category: bug label Apr 22, 2022
@kostko kostko force-pushed the kostko/fix/tee-noreg-nonactive branch from dbfb11b to 0078d3c Compare April 22, 2022 11:00
@kostko kostko force-pushed the kostko/fix/tee-noreg-nonactive branch from 0078d3c to cecf758 Compare April 22, 2022 11:06
@codecov
Copy link

codecov bot commented Apr 22, 2022

Codecov Report

Merging #4683 (cecf758) into master (73dc558) will increase coverage by 0.04%.
The diff coverage is 50.00%.

❗ Current head cecf758 differs from pull request most recent head 103470b. Consider uploading reports for the commit 103470b to get more accurate results

@@            Coverage Diff             @@
##           master    #4683      +/-   ##
==========================================
+ Coverage   66.83%   66.87%   +0.04%     
==========================================
  Files         436      436              
  Lines       48902    48916      +14     
==========================================
+ Hits        32682    32712      +30     
+ Misses      12168    12152      -16     
  Partials     4052     4052              
Impacted Files Coverage Δ
go/worker/compute/executor/committee/node.go 71.05% <50.00%> (+2.35%) ⬆️
...onsensus/tendermint/apps/beacon/state/state_vrf.go 73.33% <0.00%> (-13.34%) ⬇️
go/consensus/tendermint/apps/staking/auth.go 62.96% <0.00%> (-7.41%) ⬇️
go/worker/beacon/tx_retry.go 90.47% <0.00%> (-4.77%) ⬇️
go/consensus/api/submission.go 64.28% <0.00%> (-4.77%) ⬇️
go/consensus/tendermint/full/light.go 57.69% <0.00%> (-3.85%) ⬇️
go/worker/beacon/worker_vrf.go 64.34% <0.00%> (-3.48%) ⬇️
go/worker/common/p2p/rpc/peermgmt.go 76.43% <0.00%> (-2.55%) ⬇️
go/worker/storage/committee/checkpoint_sync.go 63.98% <0.00%> (-2.12%) ⬇️
go/consensus/tendermint/api/state.go 51.54% <0.00%> (-2.07%) ⬇️
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c2f483...103470b. Read the comment docs.

kostko added 2 commits April 22, 2022 13:40
Previously this caused additional downtime on upgrades due to capability
updates not being allowed.
@kostko kostko force-pushed the kostko/fix/tee-noreg-nonactive branch from 9c943b0 to 103470b Compare April 22, 2022 11:40
@kostko kostko enabled auto-merge April 22, 2022 11:40
@kostko kostko merged commit 6387e86 into master Apr 22, 2022
@kostko kostko deleted the kostko/fix/tee-noreg-nonactive branch April 22, 2022 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:bug Category: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants