Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/control/status: Add fields for quick overview of node status #4669

Merged
merged 1 commit into from
Apr 20, 2022

Conversation

ptrus
Copy link
Member

@ptrus ptrus commented Apr 14, 2022

TODO:

  • not sure if current runtime worker statuses make sense, maybe some should be added as well (e.g. runtime suspended)

@ptrus ptrus force-pushed the ptrus/feature/combined-node-status branch from 025fc6e to b89b267 Compare April 14, 2022 14:36
@Yawning
Copy link
Contributor

Yawning commented Apr 14, 2022

D: https://github.com/oasisprotocol/oasis-sdk/blob/main/cli/cmd/inspect/node_status.go

Oh nevermind you just altered the datastructure, so I don't need to change the command.

@ptrus ptrus force-pushed the ptrus/feature/combined-node-status branch from b89b267 to fd26f27 Compare April 14, 2022 16:00
go/consensus/tendermint/full/full.go Outdated Show resolved Hide resolved
go/consensus/api/api.go Outdated Show resolved Hide resolved
go/worker/common/api/api.go Outdated Show resolved Hide resolved
go/worker/common/committee/node.go Outdated Show resolved Hide resolved
@ptrus ptrus force-pushed the ptrus/feature/combined-node-status branch 6 times, most recently from 33fb82b to 11e9e81 Compare April 18, 2022 06:34
@ptrus ptrus marked this pull request as ready for review April 18, 2022 06:37
Copy link
Member

@kostko kostko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some minor nits.

go/worker/common/api/api.go Outdated Show resolved Hide resolved
go/consensus/api/api.go Outdated Show resolved Hide resolved
go/consensus/api/api.go Outdated Show resolved Hide resolved
go/consensus/api/api.go Outdated Show resolved Hide resolved
go/worker/common/api/api.go Outdated Show resolved Hide resolved
go/worker/common/api/api.go Outdated Show resolved Hide resolved
@ptrus ptrus force-pushed the ptrus/feature/combined-node-status branch 3 times, most recently from 94ee61c to 5fd1d8c Compare April 20, 2022 06:49
@ptrus ptrus force-pushed the ptrus/feature/combined-node-status branch from 5fd1d8c to f7407a3 Compare April 20, 2022 07:14
@codecov
Copy link

codecov bot commented Apr 20, 2022

Codecov Report

Merging #4669 (f7407a3) into master (95df7f0) will decrease coverage by 0.87%.
The diff coverage is 35.83%.

@@            Coverage Diff             @@
##           master    #4669      +/-   ##
==========================================
- Coverage   67.66%   66.79%   -0.88%     
==========================================
  Files         432      433       +1     
  Lines       48666    48786     +120     
==========================================
- Hits        32930    32585     -345     
- Misses      11730    12170     +440     
- Partials     4006     4031      +25     
Impacted Files Coverage Δ
go/consensus/tendermint/seed/seed.go 44.67% <0.00%> (-0.23%) ⬇️
go/worker/common/api/api.go 19.67% <19.67%> (ø)
go/consensus/api/api.go 41.17% <48.00%> (+18.95%) ⬆️
go/worker/common/committee/node.go 59.18% <53.84%> (-0.36%) ⬇️
go/consensus/tendermint/full/full.go 62.97% <71.42%> (-1.30%) ⬇️
...nsensus/tendermint/apps/keymanager/transactions.go 0.00% <0.00%> (-55.56%) ⬇️
go/ias/http/http.go 20.33% <0.00%> (-44.07%) ⬇️
go/runtime/host/sandbox/sandbox.go 59.85% <0.00%> (-16.20%) ⬇️
go/keymanager/api/policy_sgx.go 33.33% <0.00%> (-13.34%) ⬇️
go/worker/storage/committee/utils.go 92.30% <0.00%> (-7.70%) ⬇️
... and 49 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95df7f0...f7407a3. Read the comment docs.

@ptrus ptrus merged commit 619fb5e into master Apr 20, 2022
@ptrus ptrus deleted the ptrus/feature/combined-node-status branch April 20, 2022 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants