go/runtime/txpool: Limit outstanding transactions per sender

[kostko]

No description provided.

[Yawning]

Is there something in place to prevent unbounded growth? I guess with the accounting in add, the queue size will be at most 2 *cq.maxSize?

[kostko]

So this is only used for reinserting previously poped transactions (which are at most "batch size" long). In the worst case this could overflow the queue to be twice the max size (in case of check batches being that big -- which they are not by default) when the queue is full and batch checks are failing while new transactions are being queued.

[codecov]

Codecov Report

Merging #4665 (8381b14) into master (9e0c570) will decrease coverage by 0.15%.
The diff coverage is 87.78%.

@@            Coverage Diff             @@
##           master    #4665      +/-   ##
==========================================
- Coverage   67.07%   66.92%   -0.16%     
==========================================
  Files         431      432       +1     
  Lines       48884    48637     -247     
==========================================
- Hits        32790    32551     -239     
+ Misses      12071    12068       -3     
+ Partials     4023     4018       -5     

Impacted Files	Coverage Δ
go/runtime/host/helpers.go	70.73% <ø> (-4.78%)	⬇️
go/runtime/host/protocol/types.go	54.54% <ø> (-2.60%)	⬇️
go/runtime/transaction/transaction.go	79.51% <ø> (-1.17%)	⬇️
go/worker/compute/executor/committee/batch.go	69.69% <50.00%> (-6.07%)	⬇️
go/worker/compute/executor/committee/node.go	69.55% <51.72%> (-2.15%)	⬇️
go/runtime/txpool/transaction.go	72.22% <72.22%> (ø)
go/runtime/host/mock/mock.go	91.59% <81.81%> (-2.69%)	⬇️
go/runtime/txpool/txpool.go	77.86% <91.08%> (+2.06%)	⬆️
go/runtime/txpool/check_queue.go	100.00% <100.00%> (+15.38%)	⬆️
go/runtime/txpool/schedule_queue.go	100.00% <100.00%> (ø)
... and 34 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89ed839...8381b14. Read the comment docs.