Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

worker/registration: fix waiting for deregister event #4662

Merged
merged 1 commit into from
Apr 12, 2022

Conversation

ptrus
Copy link
Member

@ptrus ptrus commented Apr 12, 2022

Added the resuming on closed stopRegCh to one place too many in 29dbfa8

TODO:

  • update e2e tests to ensure the node is deregistered after request shutdown

@ptrus ptrus force-pushed the ptrus/bugfix/request-shutdown branch from 2728532 to 62acc1a Compare April 12, 2022 14:44
@ptrus ptrus marked this pull request as ready for review April 12, 2022 14:44
@ptrus ptrus force-pushed the ptrus/bugfix/request-shutdown branch from 62acc1a to 8baf090 Compare April 12, 2022 18:32
@ptrus ptrus force-pushed the ptrus/bugfix/request-shutdown branch from 8baf090 to 9e0c570 Compare April 12, 2022 18:58
@codecov
Copy link

codecov bot commented Apr 12, 2022

Codecov Report

Merging #4662 (9e0c570) into master (a851f30) will increase coverage by 0.10%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4662      +/-   ##
==========================================
+ Coverage   66.97%   67.07%   +0.10%     
==========================================
  Files         431      431              
  Lines       48883    48884       +1     
==========================================
+ Hits        32737    32790      +53     
+ Misses      12107    12071      -36     
+ Partials     4039     4023      -16     
Impacted Files Coverage Δ
go/worker/registration/worker.go 67.75% <ø> (-0.10%) ⬇️
go/oasis-node/cmd/common/genesis/staking.go 69.86% <100.00%> (+1.29%) ⬆️
...onsensus/tendermint/apps/beacon/state/state_vrf.go 73.33% <0.00%> (-13.34%) ⬇️
go/worker/common/committee/runtime_host.go 58.33% <0.00%> (-8.34%) ⬇️
go/runtime/host/sandbox/sandbox.go 59.15% <0.00%> (-6.70%) ⬇️
go/worker/common/p2p/dispatch.go 71.52% <0.00%> (-5.56%) ⬇️
go/worker/beacon/tx_retry.go 90.47% <0.00%> (-4.77%) ⬇️
go/consensus/api/submission.go 64.28% <0.00%> (-4.77%) ⬇️
...consensus/tendermint/apps/roothash/transactions.go 66.66% <0.00%> (-3.12%) ⬇️
go/worker/keymanager/p2p/client.go 80.95% <0.00%> (-2.39%) ⬇️
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da924ac...9e0c570. Read the comment docs.

@ptrus ptrus merged commit 89ed839 into master Apr 12, 2022
@ptrus ptrus deleted the ptrus/bugfix/request-shutdown branch April 12, 2022 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants