Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/oasis-node/cmd/control: Add runtime-stats #4596

Merged
merged 1 commit into from
Mar 23, 2022

Conversation

Yawning
Copy link
Contributor

@Yawning Yawning commented Mar 23, 2022

This is a cleaned up version of the command in the tools repository.

Fixes #4425

@Yawning Yawning changed the title go/oasis-node/cmd/control: Add runtime-status go/oasis-node/cmd/control: Add runtime-stats Mar 23, 2022
@gw0
Copy link
Contributor

gw0 commented Mar 23, 2022

If I see correctly, this PR only implements the runtime-status command to get on-demand statistics for all nodes for a runtime in a specific interval. Node operators are more concerned with the current health of its own node (not historical and not for other nodes).

It would probably be better to continuously monitor these runtime stats as counters of all runtimes running on the current node. These could then be exposed in oasis-node control status and also as Prometheus metrics (mentioned in #4425).

@kostko
Copy link
Member

kostko commented Mar 23, 2022

@gw0 Current health (for the current epoch if the node is in the executor committee) is already reported as part of the control status output (in 22.0.x) as the consensus layer is tracking liveness statistics. We will also be adding a Prometheus metric.

@Yawning Yawning force-pushed the yawning/feature/runtime-stats branch from 9f364f4 to fb24f8b Compare March 23, 2022 12:35
@Yawning Yawning enabled auto-merge March 23, 2022 12:35
This is a cleaned up version of the command in the tools repository.
@Yawning Yawning force-pushed the yawning/feature/runtime-stats branch from fb24f8b to ec74d2c Compare March 23, 2022 13:16
@Yawning Yawning merged commit 3059b60 into master Mar 23, 2022
@Yawning Yawning deleted the yawning/feature/runtime-stats branch March 23, 2022 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

go/oasis-node: Integrate the tools/runtime-stats functionality
3 participants