-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go/signature: apply options on registered contexts #4591
Conversation
c27517c
to
ed92758
Compare
Codecov Report
@@ Coverage Diff @@
## master #4591 +/- ##
==========================================
+ Coverage 66.44% 66.49% +0.04%
==========================================
Files 428 428
Lines 48512 48512
==========================================
+ Hits 32235 32256 +21
+ Misses 12336 12318 -18
+ Partials 3941 3938 -3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's also backport this.
gonna add a test to cover that unregistered malformed context branch while I'm here |
ed92758
to
504af66
Compare
backports opened 👍 |
when allowing unregistered signature contexts, still apply options for contexts that are registered