Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/runtime/host/multi: Release lock before calling into runtime #4538

Merged
merged 1 commit into from
Mar 4, 2022

Conversation

kostko
Copy link
Member

@kostko kostko commented Mar 4, 2022

Identified on the Testnet, triggered on client nodes.

@kostko kostko added the c:bug Category: bug label Mar 4, 2022
@kostko kostko force-pushed the kostko/fix/multihost-deadlock branch from a83728c to a0bb6ad Compare March 4, 2022 08:14
@kostko kostko enabled auto-merge March 4, 2022 08:42
@codecov
Copy link

codecov bot commented Mar 4, 2022

Codecov Report

Merging #4538 (a0bb6ad) into master (1850794) will decrease coverage by 0.03%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4538      +/-   ##
==========================================
- Coverage   67.08%   67.05%   -0.04%     
==========================================
  Files         424      424              
  Lines       47713    47715       +2     
==========================================
- Hits        32010    31994      -16     
- Misses      11800    11803       +3     
- Partials     3903     3918      +15     
Impacted Files Coverage Δ
go/runtime/host/multi/multi.go 75.00% <75.00%> (+4.10%) ⬆️
go/oasis-node/cmd/common/metrics/disk.go 65.51% <0.00%> (-20.69%) ⬇️
...onsensus/tendermint/apps/beacon/state/state_vrf.go 73.33% <0.00%> (-13.34%) ⬇️
go/consensus/tendermint/apps/staking/votes.go 57.89% <0.00%> (-10.53%) ⬇️
go/worker/storage/committee/utils.go 92.30% <0.00%> (-7.70%) ⬇️
go/worker/keymanager/handler.go 70.00% <0.00%> (-6.67%) ⬇️
go/worker/storage/p2p/sync/client.go 80.64% <0.00%> (-6.46%) ⬇️
...nsensus/tendermint/apps/staking/signing_rewards.go 21.62% <0.00%> (-5.41%) ⬇️
go/worker/beacon/tx_retry.go 90.47% <0.00%> (-4.77%) ⬇️
go/storage/mkvs/lookup.go 75.00% <0.00%> (-4.17%) ⬇️
... and 39 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19a0028...a0bb6ad. Read the comment docs.

@kostko kostko merged commit 8b73341 into master Mar 4, 2022
@kostko kostko deleted the kostko/fix/multihost-deadlock branch March 4, 2022 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:bug Category: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants