Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go/worker/keymanager: Transition keymanager protocol to P2P #4490

Merged
merged 7 commits into from
Feb 21, 2022
Merged

go/worker/keymanager: Transition keymanager protocol to P2P #4490

merged 7 commits into from
Feb 21, 2022

Conversation

kostko
Copy link
Member

@kostko kostko commented Feb 17, 2022

No description provided.

@kostko kostko added c:key management Category: key management c:p2p Category: P2P c:breaking/runtime Category: breaking runtime changes labels Feb 17, 2022
@kostko kostko force-pushed the kostko/feature/km-p2p branch 7 times, most recently from 8be051c to e6781e6 Compare February 18, 2022 17:42
@kostko kostko marked this pull request as ready for review February 18, 2022 17:42
@codecov
Copy link

codecov bot commented Feb 18, 2022 •
edited
Loading

Codecov Report

Merging #4490 (d189961) into master (6983322) will decrease coverage by 0.32%.
The diff coverage is 85.84%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4490      +/-   ##
==========================================
- Coverage   69.01%   68.69%   -0.33%     
==========================================
  Files         424      423       -1     
  Lines       47365    47390      +25     
==========================================
- Hits        32688    32553     -135     
- Misses      10676    10817     +141     
- Partials     4001     4020      +19
Impacted Files Coverage Δ
go/keymanager/api/api.go 80.64% <ø> (ø)
go/keymanager/api/grpc.go 39.47% <ø> (-7.59%) ⬇️
go/registry/api/api.go 59.17% <ø> (-0.90%) ⬇️
go/worker/storage/committee/node.go 76.76% <50.00%> (-1.50%) ⬇️
go/worker/common/p2p/rpc/peermgmt.go 76.43% <72.41%> (-1.09%) ⬇️
go/worker/keymanager/worker.go 65.89% <76.59%> (+0.15%) ⬆️
go/worker/keymanager/p2p/server.go 77.77% <77.77%> (ø)
go/worker/common/committee/runtime_host.go 58.33% <80.00%> (+8.33%) ⬆️
go/worker/keymanager/p2p/client.go 83.33% <83.33%> (ø)
go/worker/common/p2p/rpc/client.go 81.32% <92.15%> (+2.41%) ⬆️
... and 54 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b7cd47...d189961. Read the comment docs.

ptrus
ptrus approved these changes Feb 21, 2022
View reviewed changes
go/worker/keymanager/worker.go Outdated Show resolved Hide resolved
go/worker/keymanager/p2p/protocol.go Show resolved Hide resolved
go/worker/common/p2p/rpc/client.go Outdated Show resolved Hide resolved
@kostko kostko force-pushed the kostko/feature/km-p2p branch from e6781e6 to 8d2e65f Compare February 21, 2022 09:09
@kostko kostko force-pushed the kostko/feature/km-p2p branch from 8d2e65f to d189961 Compare February 21, 2022 09:44
@kostko kostko merged commit bbac7ab into master Feb 21, 2022
@kostko kostko deleted the kostko/feature/km-p2p branch February 21, 2022 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptrus ptrus ptrus approved these changes

@Yawning Yawning Awaiting requested review from Yawning

@peterjgilbert peterjgilbert Awaiting requested review from peterjgilbert peterjgilbert is a code owner

@pro-wh pro-wh Awaiting requested review from pro-wh pro-wh is a code owner

Assignees
No one assigned
Labels
c:breaking/runtime Category: breaking runtime changes c:key management Category: key management c:p2p Category: P2P
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kostko @ptrus