Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/runtime/scheduling: Allow a higher priority tx even if queue full #4431

Merged
merged 2 commits into from
Jan 18, 2022

Conversation

kostko
Copy link
Member

@kostko kostko commented Jan 17, 2022

No description provided.

@kostko kostko added the c:runtime/scheduler Category: runtime txn scheduler label Jan 17, 2022
@kostko kostko requested a review from ptrus January 17, 2022 10:26
@kostko kostko force-pushed the kostko/feature/rt-fullq-priority branch from 7aa182f to ace62bb Compare January 17, 2022 10:27
@kostko kostko force-pushed the kostko/feature/rt-fullq-priority branch from ace62bb to 1d0a729 Compare January 17, 2022 10:28
@codecov
Copy link

codecov bot commented Jan 17, 2022

Codecov Report

Merging #4431 (1d0a729) into master (b46166c) will increase coverage by 0.08%.
The diff coverage is 85.18%.

❗ Current head 1d0a729 differs from pull request most recent head 1ef5b76. Consider uploading reports for the commit 1ef5b76 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4431      +/-   ##
==========================================
+ Coverage   68.76%   68.84%   +0.08%     
==========================================
  Files         414      414              
  Lines       46257    46273      +16     
==========================================
+ Hits        31807    31856      +49     
+ Misses      10539    10504      -35     
- Partials     3911     3913       +2     
Impacted Files Coverage Δ
...ling/simple/txpool/priorityqueue/priority_queue.go 88.15% <85.18%> (+1.39%) ⬆️
...ensus/tendermint/apps/staking/proposing_rewards.go 56.75% <0.00%> (-5.41%) ⬇️
...nsensus/tendermint/apps/keymanager/transactions.go 50.00% <0.00%> (-2.95%) ⬇️
go/keymanager/client/client.go 78.51% <0.00%> (-2.48%) ⬇️
go/consensus/api/submission.go 66.66% <0.00%> (-2.39%) ⬇️
go/runtime/host/protocol/connection.go 70.65% <0.00%> (-2.32%) ⬇️
go/runtime/registry/host.go 75.72% <0.00%> (-1.95%) ⬇️
go/worker/beacon/worker_vrf.go 64.34% <0.00%> (-1.74%) ⬇️
go/oasis-node/cmd/node/node.go 54.59% <0.00%> (-1.74%) ⬇️
go/storage/client/client.go 83.57% <0.00%> (-1.43%) ⬇️
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60ac7ae...1ef5b76. Read the comment docs.

@kostko kostko marked this pull request as ready for review January 17, 2022 13:21
The previous one was confusing as to return the item with the lowest priority
one would call Max instead of Min.
@kostko kostko enabled auto-merge January 18, 2022 10:48
@kostko kostko merged commit 19e6fd8 into master Jan 18, 2022
@kostko kostko deleted the kostko/feature/rt-fullq-priority branch January 18, 2022 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:runtime/scheduler Category: runtime txn scheduler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants