Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/storage/client: Catch GetDiff errors early #4397

Merged
merged 1 commit into from
Dec 15, 2021

Conversation

kostko
Copy link
Member

@kostko kostko commented Dec 15, 2021

No description provided.

@kostko kostko added the c:bug Category: bug label Dec 15, 2021
@kostko kostko force-pushed the kostko/fix/storage-getdiff-earlyerr branch from 63b9a5a to e1af0dc Compare December 15, 2021 12:35
@kostko kostko marked this pull request as ready for review December 15, 2021 12:44
@codecov
Copy link

codecov bot commented Dec 15, 2021

Codecov Report

Merging #4397 (e1af0dc) into master (4556f9c) will increase coverage by 0.11%.
The diff coverage is 73.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4397      +/-   ##
==========================================
+ Coverage   69.01%   69.13%   +0.11%     
==========================================
  Files         413      413              
  Lines       46993    47006      +13     
==========================================
+ Hits        32434    32498      +64     
+ Misses      10588    10542      -46     
+ Partials     3971     3966       -5     
Impacted Files Coverage Δ
go/storage/client/client.go 74.74% <73.33%> (-0.26%) ⬇️
...onsensus/tendermint/apps/beacon/state/state_vrf.go 73.33% <0.00%> (-13.34%) ⬇️
go/common/cbor/codec.go 78.37% <0.00%> (-5.41%) ⬇️
go/consensus/tendermint/full/services.go 77.69% <0.00%> (-3.85%) ⬇️
go/storage/mkvs/tree.go 89.28% <0.00%> (-3.58%) ⬇️
go/worker/beacon/worker_vrf.go 66.08% <0.00%> (-1.74%) ⬇️
go/storage/mkvs/insert.go 90.47% <0.00%> (-1.37%) ⬇️
go/runtime/nodes/grpc/grpc.go 71.33% <0.00%> (-1.03%) ⬇️
go/runtime/registry/host.go 75.00% <0.00%> (-0.97%) ⬇️
go/storage/api/grpc.go 68.22% <0.00%> (-0.85%) ⬇️
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae68fd6...e1af0dc. Read the comment docs.

@kostko kostko merged commit f7d14bf into master Dec 15, 2021
@kostko kostko deleted the kostko/fix/storage-getdiff-earlyerr branch December 15, 2021 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:bug Category: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants