Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/consensus/tendermint: Only reset executor pool after emitting block #4323

Merged
merged 1 commit into from
Oct 21, 2021

Conversation

kostko
Copy link
Member

@kostko kostko commented Oct 21, 2021

Make sure to only reset the executor pool after any timeouts have been cleared
(e.g. when an empty block is emitted) as otherwise there could be a stale
timeout.

@kostko kostko added the c:bug Category: bug label Oct 21, 2021
Make sure to only reset the executor pool after any timeouts have been cleared
(e.g. when an empty block is emitted) as otherwise there could be a stale
timeout.
@kostko kostko force-pushed the kostko/fix/suspended-runtime-timeout branch from 1037fdd to a3f889a Compare October 21, 2021 10:21
@kostko kostko marked this pull request as ready for review October 21, 2021 10:38
@codecov
Copy link

codecov bot commented Oct 21, 2021

Codecov Report

Merging #4323 (a3f889a) into master (68fbd04) will decrease coverage by 0.07%.
The diff coverage is 28.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4323      +/-   ##
==========================================
- Coverage   68.63%   68.56%   -0.08%     
==========================================
  Files         411      411              
  Lines       47370    47375       +5     
==========================================
- Hits        32511    32481      -30     
- Misses      10825    10853      +28     
- Partials     4034     4041       +7     
Impacted Files Coverage Δ
go/consensus/tendermint/apps/roothash/roothash.go 74.48% <28.57%> (-0.87%) ⬇️
go/oasis-node/cmd/common/metrics/disk.go 65.51% <0.00%> (-20.69%) ⬇️
go/storage/api/context.go 87.87% <0.00%> (-12.13%) ⬇️
go/oasis-node/cmd/common/metrics/resource.go 84.00% <0.00%> (-8.00%) ⬇️
go/runtime/host/protocol/connection.go 62.16% <0.00%> (-6.18%) ⬇️
go/consensus/api/submission.go 66.66% <0.00%> (-4.77%) ⬇️
go/consensus/tendermint/apps/staking/state/gas.go 84.21% <0.00%> (-3.51%) ⬇️
go/sentry/api/grpc.go 56.25% <0.00%> (-3.13%) ⬇️
go/keymanager/client/client.go 76.03% <0.00%> (-2.48%) ⬇️
go/worker/storage/committee/node.go 75.99% <0.00%> (-1.80%) ⬇️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcd2cb6...a3f889a. Read the comment docs.

@kostko kostko merged commit c122a79 into master Oct 21, 2021
@kostko kostko deleted the kostko/fix/suspended-runtime-timeout branch October 21, 2021 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:bug Category: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants